Git Product home page Git Product logo

Comments (8)

vdboor avatar vdboor commented on May 30, 2024

Which version of Django are you using? This module has been tested on Django 1.11

from sphinxcontrib-django.

alexgleason avatar alexgleason commented on May 30, 2024

Hi, I'm using Django 2.0

from sphinxcontrib-django.

vdboor avatar vdboor commented on May 30, 2024

Ah, it seems that field.rel should be field. remote_field instead. I haven't tested this app on 2.0 yet, but you can provide a pull request that fixes Django 2.0 compatibility (and keeps 1.11 compat)

from sphinxcontrib-django.

atodorov avatar atodorov commented on May 30, 2024

@vdboor I did change this to field.remote_field.model, fixed another typo unrelated to this and I still see errors about missing name and model attributes. I think these are happening then the FK relation is specified as string not as a model.

I'd love to contribute and make some fixes but it looks like you don't have any tests at all and you claim the package is production stable and working with Django 2.0 while it clearly isn't. Without tests I really have no idea what I'm changing in the code and if I'm not breaking anything else.

from sphinxcontrib-django.

mauler avatar mauler commented on May 30, 2024

@atodorov can you send me the fixes? I am also using django 2.0

from sphinxcontrib-django.

atodorov avatar atodorov commented on May 30, 2024

@mauler I didn't manage to complete them b/c there were other unrelated issues and I didn't have time for them. I will get back to this once I really need it for my project, which is to say not probably very soon.

from sphinxcontrib-django.

vdboor avatar vdboor commented on May 30, 2024

This is now fixed in the master branch (see 6525fb0). I'm a bit cautious to release a new version already because I haven't tested this code on a full Django 2.0 project yet. If one of you could do that, I'd be really happy about it!

The first unit testing code was added as well, something that is really needed!

from sphinxcontrib-django.

vdboor avatar vdboor commented on May 30, 2024

Nevermind -- after adding some tests I've released v0.3!

from sphinxcontrib-django.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.