Add JavaScript Linter about speedtracker HOT 12 CLOSED

I agree! I like ESlint. What are your thoughts?

from speedtracker.

KISS on that linter, please. ESLint brings with it a world of noise and some particularly distracting configuration likely to lead to pedantic conversation in PRs. I would only recommend ESLint for an organization with a highly cohesive team of 6-12+ individuals.

My suggestion: http://standardjs.com/

We could integrate with Travis to do linting of new PRs?

Yes. And use a pre-commit hook to stop the commit before it results in bad code entering the system and hitting CI. Hooks are relatively easy to set-up. Here's an example using ghooks.

from speedtracker.

I also prefer ESLint. In my projects I use ESLint with the airbnb configuration.

from speedtracker.

I can take the issue if you want...

from speedtracker.

@danielbayerlein that would be great!

We could integrate with Travis to do linting of new PRs?

from speedtracker.

We could integrate with Travis to do linting of new PRs?

Sure 👍

from speedtracker.

If we can settle on Standard I'll get a PR together for linting with pre-commit hook and CI integration.

from speedtracker.

I'm quite happy with using Standard.

from speedtracker.

@jhabdas I would also put on JavaScript Standard Style at this time.

from speedtracker.

@eduardoboucas preferences? https://standardjs.com/#is-there-a-readme-badge

from speedtracker.

I'd say the small one, but happy to go with your choice. :)

from speedtracker.

@eduardoboucas Re the small one. As soon as we add badge two is what I was thinking, for consistency. Until then I felt the big one was prettier and stood out more. 💄 really, but it hit my heart when I thought of the old badges we used to use on the Web.

from speedtracker.