Git Product home page Git Product logo

Comments (12)

simplesagar avatar simplesagar commented on August 21, 2024

Hey Steven/Kiran, just wanted to let you know this hasn’t fallen off our radar. I think we should have something for you early next week to try out.

from speakeasy.

TristanSpeakEasy avatar TristanSpeakEasy commented on August 21, 2024

Hey Team, we have just released a new version of the generator which supports hiding globals from the method signature which should get you what you want in terms of DX

To hide the global use the x-speakeasy-globals-hidden extension documented here: https://www.speakeasyapi.dev/docs/customize-sdks/globals#hiding-global-parameters-from-method-signatures

I have also added a x-speakeasy-max-method-params extension that you can define at the document level or operation level to allow you to control the shape of the signature more granularly if you wanted different handling of this per operation docs here: https://www.speakeasyapi.dev/docs/customize-sdks/methods#configuring-method-signatures

Let me know how you get on or if you need any additional help configuring this

from speakeasy.

simplesagar avatar simplesagar commented on August 21, 2024

How did that work out for you ?

from speakeasy.

simplesagar avatar simplesagar commented on August 21, 2024

Awesome let us know if you need any help on the rest of the setup. Like package publishing or anything else

from speakeasy.

simplesagar avatar simplesagar commented on August 21, 2024

Looking

from speakeasy.

simplesagar avatar simplesagar commented on August 21, 2024

To confirm Kiran you ran speakeasy configure github to setup the GH workflow files ? Asking as in noticed you’re workflow is using an older version of our GH automation

from speakeasy.

ThomasRooney avatar ThomasRooney commented on August 21, 2024

Hey Kiran, we don't currently expect that our actions are triggered on a PR; because the "context" under which the github action runs is just "make a PR with a change to the default-branch of the repo, given a new openapi specification". In particular we're expecting GITHUB_REF to be the default branch of the repo (usually main).

So I'd just drop:

  push:
    branches:
      - main
      - release
  pull_request:
    branches:
      - main

We could fix this up for you in a PR if you want?

from speakeasy.

simplesagar avatar simplesagar commented on August 21, 2024

Sorry for the delay, it got us talking about how to better support sub directories. Sending now

from speakeasy.

simplesagar avatar simplesagar commented on August 21, 2024

Here you go πŸ‘‰ dubinc/dub-ts#57
β€’ Fix .github/sdk_generation.yml to use our latest action. Setup through speakeasy configure github
β€’ Change target repo to output: ./typescript and move speakeasy config to root.
I suspect this didnt work out of the box because the SDK or github files was manually moved at some point.

from speakeasy.

simplesagar avatar simplesagar commented on August 21, 2024

If you run into any more issues we can hop on a call and sort it out quick.
( we are split across PST and GMT in case that’s easier for Kiran)

from speakeasy.

simplesagar avatar simplesagar commented on August 21, 2024

πŸŽ‰ PR created πŸ™‚ dubinc/dub-ts#58

from speakeasy.

simplesagar avatar simplesagar commented on August 21, 2024

Hey Kiran yup easy enough to do. Two ways:
β€’ interactive option: use speakeasy configure targets to change the output directory or just remove the output field from the workflow file https://github.com/dubinc/dub-node/blob/main/.speakeasy/workflow.yaml#L10
β€’ same for github, just remove the output directory option https://github.com/dubinc/dub-node/blob/main/.github/workflows/sdk-generation.yml#L26
Then on next gen it will generate into the root and you can delete typescript

from speakeasy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.