Comments (6)
Note sure if this is useful (given the extraneous prefix and suffix text in the source text), but the "difference message" in the DifferenceDescription
object returned from org.spdx.utility.compare.LicenseCompareHelper.isTextStandardLicense()
says:
Variable text rule combined-bullet-Clause5 did not match the compare text starting at line spdx/Spdx-Java-Library#38 column spdx/Spdx-Java-Library#1 "5" while processing rule var: combined-bullet-Clause5. Last optional text was not found due to the optional difference:
Normal text of license does not match starting at line spdx/Spdx-Java-Library#1 column spdx/Spdx-Java-Library#4 "an" when comparing to template text "Apache License 1.1
"
from spdx-java-library.
I'm seeing the same behaviour with the Apache-1.0
text published by Apache too.
from spdx-java-library.
This could be the same problem of dealing with multiple spaces when matching with a var rule as in spdx/license-list-XML#2264 and spdx/license-list-XML#2266. There are multiple spaces in point 5 and it has a var rule.
from spdx-java-library.
I verified that replacing all new lines and multiple spaces by single spaces results in the Apache-1.1 text to be correctly identified but not the Apache-1.0 text.
The Apache 1.0 text differs in bullet 5:
"appear in their names, without prior" instead of "appear in their name, without prior" so this is a bug in the template.
from spdx-java-library.
This should now be fixed with PR #221
from spdx-java-library.
This should now be fixed with PR #221
Minor clarification: this is still failing, but that's due to spdx/license-list-XML#2259 and spdx/license-list-XML#2270 (i.e. PR #221 has fixed any Spdx-Java-Library specific problems involved in this behaviour).
from spdx-java-library.
Related Issues (20)
- Update CI to flag any new quality issues
- LicenseCompareHelper: EPL-2.0 license text published by Eclipse Foundation not recognised HOT 3
- LicenseCompareHelper: BSD-2-Clause license text not recognised HOT 2
- In need of a canonical way to add license texts for licenseRefs / Maybe bugged? HOT 4
- LicenseCompareHelper: GPL-2.0 license text not recognised HOT 2
- Question HOT 2
- Refactor nonOptionalTextToPatterns HOT 2
- Verify error when license exceptions are used in an expression in LicenseConcluded but not in LicenseInfoInFile HOT 2
- Official Apache-1.1 license text is not being matched correctly by LicenseCompareHelper.matchingStandardLicenseIdsWithinText() HOT 1
- Official GPL-1.0 license text is not being matched correctly by LicenseCompareHelper.isTextStandardLicense() HOT 1
- Potential enhancement: LicenseCompareHelper.isTextStandardLicense().getDifferenceMessage() should sort by line then column
- Official CC-BY-4.0 license text is not being matched correctly by LicenseCompareHelper.isTextStandardLicense() HOT 3
- Inconsistent behaviour between LicenseCompareHelper methods when called with official MIT license text HOT 1
- How to normalize the text for regex matching in src/main/java/org/spdx/utility/compare/TemplateRegexMatcher.java
- Add API to return licenses as a map in addition to list HOT 1
- Method `LicenseInfoFactory::getListedLicenseById` never returns `null` HOT 1
- Official MIT license text is not recognized as MIT by LicenseCompareHelper.isStandardLicenseWithinText HOT 4
- StringIndexOutOfBoundsException exception from org.spdx.utility.compare.TemplateRegexMatcher.findTemplateWithinText() HOT 1
- Column in DifferenceDescription returned by LicenseCompareHelper.isTextMatchingTemplate is not correct HOT 1
- TemplateRegexMatcher.getStartRegex sometimes returns a regex that matches with an index before the license start HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spdx-java-library.