Git Product home page Git Product logo

Comments (6)

pmonks avatar pmonks commented on June 16, 2024

Note sure if this is useful (given the extraneous prefix and suffix text in the source text), but the "difference message" in the DifferenceDescription object returned from org.spdx.utility.compare.LicenseCompareHelper.isTextStandardLicense() says:

Variable text rule combined-bullet-Clause5 did not match the compare text starting at line spdx/Spdx-Java-Library#38 column spdx/Spdx-Java-Library#1 "5" while processing rule var: combined-bullet-Clause5.  Last optional text was not found due to the optional difference:
	Normal text of license does not match starting at line spdx/Spdx-Java-Library#1 column spdx/Spdx-Java-Library#4 "an" when comparing to template text "Apache License 1.1

"

from spdx-java-library.

pmonks avatar pmonks commented on June 16, 2024

I'm seeing the same behaviour with the Apache-1.0 text published by Apache too.

from spdx-java-library.

sdheh avatar sdheh commented on June 16, 2024

This could be the same problem of dealing with multiple spaces when matching with a var rule as in spdx/license-list-XML#2264 and spdx/license-list-XML#2266. There are multiple spaces in point 5 and it has a var rule.

from spdx-java-library.

sdheh avatar sdheh commented on June 16, 2024

I verified that replacing all new lines and multiple spaces by single spaces results in the Apache-1.1 text to be correctly identified but not the Apache-1.0 text.
The Apache 1.0 text differs in bullet 5:
"appear in their names, without prior" instead of "appear in their name, without prior" so this is a bug in the template.

from spdx-java-library.

goneall avatar goneall commented on June 16, 2024

This should now be fixed with PR #221

from spdx-java-library.

pmonks avatar pmonks commented on June 16, 2024

This should now be fixed with PR #221

Minor clarification: this is still failing, but that's due to spdx/license-list-XML#2259 and spdx/license-list-XML#2270 (i.e. PR #221 has fixed any Spdx-Java-Library specific problems involved in this behaviour).

from spdx-java-library.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.