Git Product home page Git Product logo

Comments (4)

armintaenzertng avatar armintaenzertng commented on May 28, 2024

I suggest adding SpdxConstants.PROP_DOCUMENT_NAMESPACE to SKIPPED_PROPERTIES here

This way it will get ignored here and no value with name "documentNamespace" will be added to the document in the modelStore

from spdx-java-library.

goneall avatar goneall commented on May 28, 2024

thus, one of the procedures -- either generating a document from scratch or deserializing an existing one -- seems to be buggy.

Agree

This also raises the question of why the documentNamespace property is desirable in the first place, as it seems to simply mirror the documentUri.

These are the same - the reason for the documentNamespace in the serialized document is to have a place to store it even though it is not technically a property of the document itself. This isn't needed in some formats, like RDF, which natively support namespaces.

I suggest adding SpdxConstants.PROP_DOCUMENT_NAMESPACE to SKIPPED_PROPERTIES

That does look like a good solution.

@armintaenzertng - did you want to do a pull request and see if it passes all the unit tests with this change?

from spdx-java-library.

armintaenzertng avatar armintaenzertng commented on May 28, 2024

all right, I will do that tomorrow! :)

from spdx-java-library.

armintaenzertng avatar armintaenzertng commented on May 28, 2024

I just tested it locally, the issue is resolved via spdx/spdx-java-jackson-store#38

from spdx-java-library.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.