Git Product home page Git Product logo

Comments (3)

chessPlayerDeveloper avatar chessPlayerDeveloper commented on May 30, 2024 2

Hi @freekmurze,

This is the currently RouteAttributeServiceProvider:

protected function registerRoutes(): void
{
    if (! config('route-attributes.enabled')) {
        return;
    }

    $routeRegistrar = new RouteRegistrar(app()->router);

    collect(config('directories'))->each(fn (string $directory) => $routeRegistrar->registerDirectory($directory));
}

Maybe must be?

protected function registerRoutes(): void
{
    if (! config('route-attributes.enabled')) {
        return;
    }

    $routeRegistrar = (new RouteRegistrar(app()->router))
        ->useRootNamespace('App\\');

    collect(config('route-attributes.directories'))->each(fn (string $directory) => $routeRegistrar->registerDirectory($directory));
}

The string rootNamespace is not defined and config directories not exists.

With this modification all works fine.

Thanks.

from laravel-route-attributes.

freekmurze avatar freekmurze commented on May 30, 2024

According to the tests the package is working as intended. Please submit a failing test for me to fix.

from laravel-route-attributes.

HepplerDotNet avatar HepplerDotNet commented on May 30, 2024

That also fixed my issue #12

from laravel-route-attributes.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.