spatie/ignition default config outside of appdir open_basedir issue about ignition HOT 7 CLOSED

Hello there, can you check this out, still can't use the package because the default config sits at ~/.iginition.json outside of the laravel basepath?

@rubenvanassche @freekmurze

from ignition.

20 days and no reply? Like, nothing?

"Beautiful" error page that one can't get rid of and if something goes wrong - the support is no where to be found. Awesome. And this is core part of most popular framework...

from ignition.

@fightborn Please keep it friendly. If this is urgent for you doesn't necessarily make it urgent for us.

Here are a couple of options:

1. Try to PR a fix.
2. Remove ignition from composer. Laravel will still work, and you'll see a more basic error page.

Good luck!

from ignition.

Hello @freekmurze, I'm willing to submit a PR, what would be acceptable behavior for you?

Continuing to use the home dir as the default path and allowing to change the path in a config file or changing the default path to base_path().

Thank you!

from ignition.

Thank you! Allowing the path to be changed in the config file seems like the route to go for me.

from ignition.

I came across this issue when I upgraded to Laravel 9. Rather than override this with a config file setting, would it make sense to compare the desired .iginition.json path against the open_basedir paths to see if the users home directory is allowed? Then it could be seamless and there would be no need to worry about a separate config file setting and no need to direct people to manually add a config setting to override what is likely to be a pretty common problem -- for pretty much everyone that uses open_basedir restrictions.

How about this change to the getConfigFilePath in DefaultConfigFinder.php:

    public function getConfigFilePath(): string
    {
        if (! $homeDirectory = $this->findHomeDirectory()) {
            return '';
        }

        $filepath = "{$homeDirectory}/.ignition.json";
        return @is_readable($filepath) ? $filepath : '';
    }

I just created a pull request with this solution here:
#36

from ignition.

That's a mistake for me too. You may need to replace "getenv('HOME')" with "_SERVER['document_root']"

from ignition.