Output to file about http-status-check HOT 9 CLOSED

Ok, tonight I'll make the PR.

from http-status-check.

Totally agree that the tool should have an option to write the non 2xx responses to a file. I'd accept a non-breaking fully tested pull request for this.

from http-status-check.

As I started to implement the feature, some questions appeared, like:

• If the file exists, will it be overwritten?
• Will it be necessary to check for permissions to write the file?
• Should we use an abstraction (i.e.: Flysystem) to manipulate the file?

from http-status-check.

Thank you for putting time into this.

• since we're running at the console, we can just ask the user if the file should be overwritten
• nah, just let it fail if there's no permission to write to the file
• seems like overkill, let's just use file_put_contents.

from http-status-check.

@freekmurze forgot to change old array styles to new ones in the test, late at night =). I can fix it tomorrow.

from http-status-check.

Fixed the issues reported by StyleCI and squashed the commits.
If there's anything missing, please, report. Thanks!

I'm pretty sure that the implementation could be improved and I'm open to suggestions, but this one was the simplest one from my point of view.

from http-status-check.

Implemented in v2.1.0 🎉

from http-status-check.

I opened a ticket for an idea but didn't get round to work on it myself. Come back a couple days later to see somebody implemented it - open source is a beautiful thing.

Thanks a lot @ramirovjr!

from http-status-check.

@twiebie no problem, I'm glad I could help and also thanks @freekmurze for the opportunity to contribute to the project.

from http-status-check.