Git Product home page Git Product logo

Comments (4)

sgbaird avatar sgbaird commented on June 11, 2024

materialsproject/pymatgen#1764 mentioned same issue.

Looking a bit closer at the structures, probably has to do with the presence of distances less than 0.2 between differing sites, causing atoms to "collide".

structures[0].distance_matrix
array([[0.        , 0.97919993, 1.18065832, 1.05236272, 1.2924594 ],
       [0.97919993, 0.        , 1.94263668, 1.85350771, 2.08496016],
       [1.18065832, 1.94263668, 0.        , 0.17392385, 0.15348728],
       [1.05236272, 1.85350771, 0.17392385, 0.        , 0.25348576],
       [1.2924594 , 2.08496016, 0.15348728, 0.25348576, 0.        ]])

Note that these small distances are localized to $H$ and $He$.

structures[0].atomic_numbers
(47, 24, 1, 1, 2)

from xtal2png.

sgbaird avatar sgbaird commented on June 11, 2024

Looping through all 16 generated samples

Interestingly with the higher symprec of 0.1 instead of 0.01 more None-s are produced

space_group = []
for s in structures:
    try:
        space_group.append(s.get_space_group_info(symprec=0.1)[1])
    except Exception as e:
        space_group.append(None)
        pass
print(space_group)
[1, None, None, None, 1, 1, None, None, 1, None, None, 1, None, 1, 1, None]

from xtal2png.

sgbaird avatar sgbaird commented on June 11, 2024

Better now, but still not great:

[1, 1, 1, 1, 1, 1, 8, 1, 1, 1, 1, 1, 1, 1, 1, 1]

with relax_on_decode, decode_as_primitive, and 127k iterations.

The formulas:
image

which seem somewhat better.

The images (sample-127.png):
sample-127

from xtal2png.

sgbaird avatar sgbaird commented on June 11, 2024

from Kevin:

yes, also in your case, if you'd encode the space group in the image, you could write components for the loss that penalize mismatching angles. In other contexts, I have seen such extra loss terms to help a lot

from xtal2png.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.