Comments (4)
materialsproject/pymatgen#1764 mentioned same issue.
Looking a bit closer at the structures, probably has to do with the presence of distances less than 0.2 between differing sites, causing atoms to "collide".
structures[0].distance_matrix
array([[0. , 0.97919993, 1.18065832, 1.05236272, 1.2924594 ], [0.97919993, 0. , 1.94263668, 1.85350771, 2.08496016], [1.18065832, 1.94263668, 0. , 0.17392385, 0.15348728], [1.05236272, 1.85350771, 0.17392385, 0. , 0.25348576], [1.2924594 , 2.08496016, 0.15348728, 0.25348576, 0. ]])
Note that these small distances are localized to
structures[0].atomic_numbers
(47, 24, 1, 1, 2)
from xtal2png.
Looping through all 16 generated samples
Interestingly with the higher symprec
of 0.1 instead of 0.01 more None
-s are produced
space_group = []
for s in structures:
try:
space_group.append(s.get_space_group_info(symprec=0.1)[1])
except Exception as e:
space_group.append(None)
pass
print(space_group)
[1, None, None, None, 1, 1, None, None, 1, None, None, 1, None, 1, 1, None]
from xtal2png.
Better now, but still not great:
[1, 1, 1, 1, 1, 1, 8, 1, 1, 1, 1, 1, 1, 1, 1, 1]
with relax_on_decode
, decode_as_primitive
, and 127k iterations.
which seem somewhat better.
from xtal2png.
from Kevin:
yes, also in your case, if you'd encode the space group in the image, you could write components for the loss that penalize mismatching angles. In other contexts, I have seen such extra loss terms to help a lot
from xtal2png.
Related Issues (20)
- JOSS paper review - Documentation HOT 3
- `func:` syntax issue in API docs HOT 2
- Add hardcoded reference image test once API is stable (i.e. in conjunction with results manuscript, `v1.0.0`)
- Add `element-coder` to `conda-forge` HOT 4
- Suggestion: Add CLI parameter for `max_sites`
- Bug: `xtal2png` error with fractional occupancy HOT 1
- JOSS paper review - Installation docs HOT 8
- JOSS paper review - Docs
- interpretability of models trained on xtal2png HOT 3
- Any acknowledgements that need to be added to `paper.md`? HOT 6
- Are the distance matrices periodic by default? HOT 1
- Generalization to building blocks rather than only atoms HOT 1
- Might be interesting to add GitHub action for repo-visualizer, and include the image in the contributing docs
- use `xtal2png` with `imagen-pytorch` and `matbench-genmetrics` HOT 6
- local variable 'arr' referenced before assignment due to list of lists
- Run matbench-genmetrics on the latest imagen-pytorch run (fixup mod-petti featurizer) HOT 1
- lower_tri mask type zeros out everything
- add masking to intro tutorial
- Predict synthesis routes for DFT-validated xtal2png structures
- Use something similar to Xie's decoder/denoiser architecture for the xtal2png representation (e.g. m3gnet)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from xtal2png.