reply-to has broken about wordpress-sparkpost HOT 13 CLOSED

@bartv42 Thanks for reporting. We'll look into it. Can you please post the log that you see?

from wordpress-sparkpost.

Can I email you that in private? I'd like to not share the included email
addresses.

Bart Veldhuizen

On 22 August 2016 at 16:25:35, rajumsys ([email protected]) wrote:

@bartv42 https://github.com/bartv42 Thanks for reporting. We'll look into
it. Can you please post the log that you see?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#59 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGgC1eZ65CGQh3szZ_EJbKE8SAFnyGZlks5qibFfgaJpZM4JpAsW
.

from wordpress-sparkpost.

Yeah, you can do that. But you should mask them with something else in either cases :).

mohammad.hossain
at
sparkpost.com

from wordpress-sparkpost.

True enough :)

Here's what I see in WP Maillog:

And here are the message headers in gmail:

from wordpress-sparkpost.

Thanks for the update. A quick question, did you also update wordpress recently? My guess is it might have been changed in WordPress because IMO, last release of plugin is unlikely to break this (though possible).

from wordpress-sparkpost.

Yes, I did the recent 4.6 update.

On Monday, Aug 22, 2016 at 9:22 PM, rajumsys <[email protected] (mailto:[email protected])> wrote:

Thanks for the update. A quick question, did you also update wordpress recently? My guess is it might have been changed in WordPress because IMO, last release of plugin is unlikely to break this (though possible).

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub (#59 (comment)), or mute the thread (https://github.com/notifications/unsubscribe-auth/AGgC1YdVrVkJzPg3Pw7OuHX3sL_jGdoYks5qifbpgaJpZM4JpAsW).

from wordpress-sparkpost.

Ok, thanks. I'll investigate based on both possibilities. Thanks

from wordpress-sparkpost.

So, this is interesting. Looking into the plugin code I see the following note

// wp_mail sets Reply-To as custom header (does not use phpmailer->addReplyTo)

And in WP 4.6, I see this

case 'reply_to':
                        $phpmailer->addReplyTo( $address, $recipient_name );
                        break;

from wordpress-sparkpost.

https://core.trac.wordpress.org/changeset/38058

from wordpress-sparkpost.

@bartv42 I've just created a PR(#60) . Please have a look. It'll be great if you can test it at your end and let us know.

from wordpress-sparkpost.

Okay will do. I'll let it run for a few hours to see if it works in my different scenarios. Will let you know later today. Thanks!

On Monday, Aug 22, 2016 at 10:29 PM, rajumsys <[email protected] (mailto:[email protected])> wrote:

@bartv42 (https://github.com/bartv42) I've just created a PR(#60 (#60)) . Please have a look. It'll be great if you can test it at your end and let us know.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub (#59 (comment)), or mute the thread (https://github.com/notifications/unsubscribe-auth/AGgC1ZmmQUwNdN79OOjMHU26ApZStS8pks5qigaPgaJpZM4JpAsW).

from wordpress-sparkpost.

It's working well so far, seems to me that you fixed it ;)

from wordpress-sparkpost.

v2.4.1 released with this fix. Thanks a lot @bartv42 for reporting

from wordpress-sparkpost.