[ENG-349] Archive/Zip about spacedrive HOT 10 OPEN

Agreed with @ericson.ds999, we don't need to broke this job to steps, it can be a 1 big bulky zip and unzip job that does it thing through the library. I don't think pausing it or remembering where it is makes sense here too. Let's not make this complicated and keep it as simple as possible. It just needs work.

from spacedrive.

I don't think that this job can be broken in steps at all. Steps are only needed when we can interrupt the job to be resumed later, which isn't the case. But the new task system enables periodically pauses with a mutable state between them. Without the restriction of being needed to be serializable. On a compression task we would be able to pause it in memory, but if the app was closed, it would need to be started from the beginning.

from spacedrive.

Oh sorry I missed that part, thanks @brxken128! Do you know about this @ericson.ds999?

from spacedrive.

and the current job system doesn't allow for a mutable object to be shared between job steps (which is what the zip crate would require)

from spacedrive.

Why is this blocked?

from spacedrive.

Yeah, we still need zip-slip protection as well as special path handling on Windows (most likely), and the current job system doesn't allow for a mutable object to be shared between job steps (which is what the zip crate would require).

from spacedrive.

As mentioned on Slack, plan is to use a already ready zip crate

from spacedrive.

Might not be blocked but not a priority atm.

from spacedrive.

I'm pretty sure this is still not possible given the current state of the job system. I will look further into it, but we need a mutable state which is not serialised. Maybe a serde(skip)will work, but the job will not be resumable at all.

from spacedrive.

I'm currently unable to continue with this as we're not able to mutably share objects between job steps, when the objects in question cannot be serialized/deserialized.

from spacedrive.