Git Product home page Git Product logo

Comments (4)

christoph-buente avatar christoph-buente commented on June 2, 2024

Hi, i have this issue on my tasklist. I'm not sure, if this behaviour goes into the rosemary library. Or is the "unknown" value generally useless, with any key? So should rosemary prevent all key/value pairs with unknown?

from rosemary.

o5k6 avatar o5k6 commented on June 2, 2024

A value of "unknown" is sometimes used for other keys, like access or speed restrictions, or even house numbers. In my view, "unknown" does not make much sense in those cases either (if anything, I would prefer a fixme=* tag set by mappers, not software), though I cannot completely rule out the existence of special cases where *=unknown might be useful, and the views of others might vary.

However, replacing a former value yes|no|whatever with unknown discards the (alledged) knowledge previously entered by someone else in favour of the user's ignorance on the matter. Exception: if a user enters "yes" and then becomes unsure, he should be allowed to remove the tag set by himself (but not replace it with "unknown"). In other cases, I do not think it should at all be possible on wheelmap to remove the wheelchair tag.

Suggestion: forbid wheelchair=unknown or even =unknown in general, and allow the removal of wheelchair= only if the previous value was entered by the same user. Which part of this suggestion falls in the domain of the rosemary lib or its wheelmap instance, I cannot tell.

from rosemary.

christoph-buente avatar christoph-buente commented on June 2, 2024

Ok, this sounds like a bit more complicated logic, which should not be baked into the pure client library. I will fix this with the wheelmap.org website and leave rosemary agnostic to any value other than "blank".

from rosemary.

christoph-buente avatar christoph-buente commented on June 2, 2024

A new version has been deployed to the wheelmap.org website, preventing the submission of wheelchair=unknown to the osm. Instead this tag will be ommited when creating a new node. It will keep the same value, when it had another value before. We'll see how many users complain about the fact, that they cannot revert their changes. If there was a high demand, i would implement a more elaborate solution.

from rosemary.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.