Add not_if and only_if, also standard cases such as exists/not exists about line HOT 4 CLOSED

I'll probably add something to allow folks to avoid your initial situation. Repeated inserts is a really nasty thing to have happen.

from line.

HI mrswadge,

The sample filters are intended to be idempotent. They are designed to do what you want to tell them to do. They should not insert a line multiple times. Do you have an example of using filter_lines that inserts lines over and over again?

Thinking about it, this might be the case you have a problem with.

In your example above if the newline you insert matches the regex in match then every time the resource runs lines will be inserted. Both after the original match and after the newline match. I can make that experience safer by disallowing that case. The replace filter (not yet published) won't let you insert lines that would be replaced for instance.

Thanks,
Mark

from line.

Hi Mark,

I've worked out what my issue was now and I believe that it is working as intended. My action was modifying a java.security file, specifically the area below.

#
# Default login configuration file
#
#login.config.url.1=file:${user.home}/.java.login.config

I was using the following code

def to_regexp(value, flags=Regexp::IGNORECASE)
  return (value.instance_of? Regexp) ? value : Regexp.new("#{Regexp.escape(value)}", flags)
end

match = to_regexp('login.config.url.1')
newline = 'login.config.url.1=file:${java.home}/lib/security/Application.login.config'

filter_lines "modify #{path}/java.security" do
  path "#{path}/java.security"
  filters after: [match, newline, :last]
end

First time it correctly inserted the line:

#
# Default login configuration file
#
#login.config.url.1=file:${user.home}/.java.login.config
login.config.url.1=file:${java.home}/lib/security/Application.login.config

Each subsequent time it added a new line.

#
# Default login configuration file
#
#login.config.url.1=file:${user.home}/.java.login.config
login.config.url.1=file:${java.home}/lib/security/Application.login.config
login.config.url.1=file:${java.home}/lib/security/Application.login.config

To stop this, I have now changed my match to the following and this is now idempotent.

match = to_regexp('#login.config.url.1')

I will close off this issue.

Cheers,
Stuart

from line.

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

from line.