MultiFileDiffReader doesn’t handle messages in diff that certain files are only available in specific version. about go-diff HOT 5 CLOSED

Would you accept a pull request to fix this?

from go-diff.

Thanks for the proposal. I think we would. It seems like the set of inputs we understand will only increase + the empty diff makes sense. @eseliger @mrnugget thoughts? Any concerns around the nil time param?

from go-diff.

Don't think so, we should probably make sure we do proper nil checks in our codebase, but that shouldn't affect work in this repository.
I couldn't find any resources by a quick google search that defined this behavior, and I am struggling to understand what it actually means. So if it's only in source_a, that basically means deleted, right? And the other way around, that means it's created?
If so, I would have expected the expected result you posted would be [2].NewName: "source_b/file_3.txt and [2].OrigName: nil, so I must be missing something :) Can you clarify how the "Only in ..." is different from deleted/created?

from go-diff.

@eseliger yes, you are right :) It mostly clarifies deleted/created files (except maybe files that actually have been renamed, but this couldn't be handled, as they will be marked as deleted with originName and created with NewName). It will just require an extra step for checking whether source_a should be marked as OrigSource or NewSource.

from go-diff.

Sounds like it's another way to express deleted/created in diffs and supporting that would just be additional functionality that would have no effect on the existing code. If so, yeah, I think we should accept a PR :)

from go-diff.