Comments (6)
@michaelti more than happy to review a PR for you, it's a great way to learn. 👍 welcome to the Rails community.
from devise_campaignable.
@michaelti this is now available in 0.2.4
on Rubygems.
from devise_campaignable.
@michaelti I totally agree this would be a good idea.
The application I use this for runs DelayedJob.so the call to MailChimp is pushed into the background and doesn't risk preventing the save, which is why I've not come.accross this myself.
It shouldn't be a complicated change, we'll just rescue from MailChimp in the callback.
I'll try and take a closer.look.
from devise_campaignable.
@michaelti had a quick look at the code. I think best approach would be to rescue on this method: https://github.com/sorry-app/devise_campaignable/blob/master/lib/devise_campaignable/adapters/mailchimp.rb#L8
In a similar way to we.do on the unsibscribe, swallowing and logging the error, albeit, without re-raising: https://github.com/sorry-app/devise_campaignable/blob/master/lib/devise_campaignable/adapters/mailchimp.rb#L32
Feel free to put together a PR as I likely won't get chance myself.until next week at some.poont. 🙂
from devise_campaignable.
@SirRawlins Thanks for the quick response! This solution makes sense to me. I will try my hand at a PR – admittedly I'm a beginner with Rails so you'll want to check it over. Cheers :)
from devise_campaignable.
@SirRawlins Thanks again!
from devise_campaignable.
Related Issues (7)
- undefined method 'delay' for Devise::Models::Campaignable::Adapters::Mailchimp HOT 6
- Requires you to add Gibbon dependancy manually. HOT 24
- how to disable / mock on the test environment? HOT 2
- Vendor Name Default HOT 5
- Possible to disable in development / test modes? HOT 3
- Additional Fields not working HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from devise_campaignable.