Git Product home page Git Product logo

Comments (3)

sorentwo avatar sorentwo commented on August 24, 2024 1

Thanks for explaining your use case. I've thought about this a bit, and I'm not convinced it's valuable to break 7 states into 4 groups with fuzzy names and ambiguous definitions. For example, retryable is a "failure" state, and cancelled doesn't necessarily mean there was a failure.

I'm in favor of enhancing state definitions, but these helpers are something you'll have to add to your application.

from oban.

sorentwo avatar sorentwo commented on August 24, 2024

Thanks for the suggestion (and the PR). Can you provide a concrete use case for categories of job states?

from oban.

NetonD avatar NetonD commented on August 24, 2024

Sure, I can, the following example is a piece of code that I'm using to list the reports requests that can fail for a bunch of reasons and I need show if the report(represented by a Oban.Job) is running, crashes or if it running/waiting, so I query the jobs and show then in a phoenix template that has this function:

  def status(status) do
    cond do
      status in ~w(available retryable scheduled) -> "Waiting"
      status == "completed" -> "Finished"
      status == "executing" -> "Running"
      true -> "Failed"
    end
  end

But is weird my interface layer knows by hard code the states of Oban, so this can turn into:

def status(status) do
  case status do
    status when status in Oban.Job.states(:waiting) -> "Waiting"
    status when status in Oban.Job.states(:up) -> "Running"
    :completed -> "Finished"
    _ -> "Failed"
  end
end

from oban.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.