Git Product home page Git Product logo

Comments (11)

kali avatar kali commented on July 17, 2024

that's interesting indeed :) I'll have a look soon-ish. Thanks :)

from dinghy.

dten avatar dten commented on July 17, 2024

this line is doing the same for ios apps and it's causing me to hit max path https://github.com/snipsco/dinghy/blob/master/src/ios/xcode.rs#L39

commenting out that line and it's alive again

from dinghy.

kali avatar kali commented on July 17, 2024

Ok, by any chance, do you happen not to have a .gitignore file around that skips target ? I think this is the reason why you got in trouble, as dinghy uses https://docs.rs/ignore/0.1.9/ignore/ to guess what to copy (to target/ first, and then to the device).

Removing it on one of my project leads to absurd behaviour of a different kind, but still aberrant (infinite loop while copying stuff in target).

I think the best way to go is a fix that explicitely ignores target/, but it would be nice if you could confirm the absence of .gitignore in your project.

from dinghy.

dten avatar dten commented on July 17, 2024

I don't have one because that project uses hg not git
Guess I'll do more yak shaving and add hg support to ignore :p
I think for people who use other things though target should definitely be filtered regardless

from dinghy.

kali avatar kali commented on July 17, 2024

yep, doing that right now.

from dinghy.

kali avatar kali commented on July 17, 2024

thanks for confirming the bug

from dinghy.

dten avatar dten commented on July 17, 2024

Why does the android one copy the files by the way? I don't see that it does anything with them.

from dinghy.

kali avatar kali commented on July 17, 2024

you do not require them per se... but many times, tests rely on the presence of test data in a separate file that is read by the test.
So the strategy is to copy the project code in a predictable place, and have the test checking the environment to know where to look for.

from dinghy.

kali avatar kali commented on July 17, 2024

i have pushed a 0.2.8 that will always ignore /target/. I'm pretty sure this will bite me some day, but I'll deal with it at that time :)

from dinghy.

dten avatar dten commented on July 17, 2024

well it gets further, but i get a failure trying to run the tests on android cause dinghy is a dir not an executable

from dinghy.

dten avatar dten commented on July 17, 2024

if you're looking at this don't worry. i was working on a PR and have fixed it in that :)

from dinghy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.