Describe the bug When I try to deploy the template it fails in th

Hello <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-ur

Template deployment ends up with ROLLBACK status about awsdetonationlab HOT 2 CLOSED

mgmacias95 commented on June 21, 2024

Template deployment ends up with ROLLBACK status

from awsdetonationlab.

Comments (2)

sonofagl1tch commented on June 21, 2024 1

looking at this bash i was using a full string match as my conditional which worked before the aws template updates. looks like now we need more of an "if a string contains substring" type of conditional. similar to the code snippet below.

string='My long string'
if [[ $string == *"My long"* ]]; then
  echo "It's there!"
fi

https://stackoverflow.com/questions/229551/how-to-check-if-a-string-contains-a-substring-in-bash

from awsdetonationlab.

mgmacias95 commented on June 21, 2024

Hello @sonofagl1tch,

After updating AMIs used in the CF template in 3f4cbfd, the template was still failing:

I disabled rolling back when the template failed so I was able to do some checks in the environment and get further information about the error. I accessed bastion machine and found out the bastion_bootstrap.sh script is failing:

# /tmp/bastion_bootstrap.sh --banner https://raw.githubusercontent.com/sonofagl1tch/AWSDetonationLab/master/artifacts/banner_message.txt --enable true --tcp-forwarding true --x11-forwarding false
checkos Ended
BANNER_PATH = https://raw.githubusercontent.com/sonofagl1tch/AWSDetonationLab/master/artifacts/banner_message.txt
Creating Banner in /etc/ssh_banner
curl  -s https://raw.githubusercontent.com/sonofagl1tch/AWSDetonationLab/master/artifacts/banner_message.txt > /etc/ssh_banner
[INFO] Installing banner ...
Setting up bastion session log in /var/log/bastion/bastion.log
ln: failed to create hard link ‘/var/log/bastion/.bastion.log’: File exists
Value of TCP_FORWARDING - true
Value of X11_FORWARDING - false
[ERROR] Unsupported Linux Bastion OS

Searching in the script's code, I found out where the error was being raised:

AWSDetonationLab/additionalInstallationScripts/bastion_bootstrap.sh

Lines 582 to 598 in e3a7078

 release=$(osrelease) 

 # Ubuntu Linux 

 if [ "$release" == "Ubuntu" ]; then 

 #Call function for Ubuntu 

 ubuntu_os 

 # AMZN Linux 

 elif [ "$release" == "AMZN" ]; then 

 #Call function for AMZN 

 amazon_os 

 # CentOS Linux 

 elif [ "$release" == "CentOS" ]; then 

 #Call function for CentOS 

 cent_os 

 else 

 echo "[ERROR] Unsupported Linux Bastion OS" 

 exit 1 

 fi

It seems the result from osrelease function isn't correct. Reviewing that function:

AWSDetonationLab/additionalInstallationScripts/bastion_bootstrap.sh

Lines 57 to 69 in e3a7078

 function osrelease () { 

 OS=`cat /etc/os-release | grep '^NAME=' | tr -d \" | sed 's/\n//g' | sed 's/NAME=//g'` 

 if [ "$OS" == "Ubuntu" ]; then 

 echo "Ubuntu" 

 elif [ "$OS" == "Amazon Linux" ]; then 

 echo "AMZN" 

 elif [ "$OS" == "CentOS Linux" ]; then 

 echo "CentOS" 

 else 

 echo "Operating System Not Found" 

 fi 

 echo "${FUNCNAME[0]} Ended" >> /var/log/cfn-init.log 

 }

It seems the following command is returning a wrong value:

# cat /etc/os-release | grep '^NAME=' |  tr -d \" | sed 's/\n//g' | sed 's/NAME=//g'
Amazon Linux AMI

But I don't know if replacing content in line 61 would be a good fix, since it was changed here:
awslabs/amazon-guardduty-tester@9fb76df#diff-18583a0977c9ce589518e28d2ef9a78c
Am I using an old instance by error when I changed AMIs?

Best regards,
Marta

from awsdetonationlab.

Template deployment ends up with ROLLBACK status about awsdetonationlab HOT 2 CLOSED

Comments (2)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	release=$(osrelease)
	# Ubuntu Linux
	if [ "$release" == "Ubuntu" ]; then
	#Call function for Ubuntu
	ubuntu_os
	# AMZN Linux
	elif [ "$release" == "AMZN" ]; then
	#Call function for AMZN
	amazon_os
	# CentOS Linux
	elif [ "$release" == "CentOS" ]; then
	#Call function for CentOS
	cent_os
	else
	echo "[ERROR] Unsupported Linux Bastion OS"
	exit 1
	fi

	function osrelease () {
	OS=`cat /etc/os-release \| grep '^NAME=' \| tr -d \" \| sed 's/\n//g' \| sed 's/NAME=//g'`
	if [ "$OS" == "Ubuntu" ]; then
	echo "Ubuntu"
	elif [ "$OS" == "Amazon Linux" ]; then
	echo "AMZN"
	elif [ "$OS" == "CentOS Linux" ]; then
	echo "CentOS"
	else
	echo "Operating System Not Found"
	fi
	echo "${FUNCNAME[0]} Ended" >> /var/log/cfn-init.log
	}