composer hosted packages.json duplicated key about nexus-repository-composer HOT 3 CLOSED

@TheBay0r, you're correct. It snuck in as part of the main hosted commit in #12, basically what looks to be happening here is when you have multiple versions of the same component it blows up because it can't collect those when there's a duplicate.

One of the issues with doing this on a shoestring, I suppose, is the relative lack of manual testing along with a total lack of integration tests (though we're working on the latter).

It should be an easy fix, let me take a quick look.

from nexus-repository-composer.

@TheBay0r, I have a fix out for master in #16 for this issue. Thanks for finding it, as it's always helpful when we have some outside support for our open-source work like this. My basic plan is to find someone who has the bandwidth to review outside of work hours, then get this into master, and pull it back into the current group work before I merge that down.

Some notes for you (and the audience at home), this also reinforces the somewhat tentative nature of this project. We're trying to get some useful functionality out to you, but I can't promise there won't be problems like this (due to my own oversight or a lack of dedicated QA) or the introduction of breaking changes (I can see a couple candidates for that having to do with broader support for upstream repositories), even assuming I'm around to work on this stuff.

from nexus-repository-composer.

@fjmilens3 Thanks for taking care of this! Mistakes can happen and I wish I could provide some more extensive testing.

I gave your branch a shot and the 500 is definitely resolved. Publishing and pulling packages worked fine. We started integrating it into our pipeline and I will keep you posted if we find any more issues.

from nexus-repository-composer.