Git Product home page Git Product logo

Comments (8)

SVilgelm avatar SVilgelm commented on August 28, 2024 1

so, it would be great if nancy can do it automatically, I mean we don't need to run it like go list -m all | nancy

from nancy.

zendern avatar zendern commented on August 28, 2024

@DarthHater maybe pull the trigger on removing this in v1.0??

from nancy.

SVilgelm avatar SVilgelm commented on August 28, 2024

Why the go.sum should be removed? Why we cannot use both options?

from nancy.

SVilgelm avatar SVilgelm commented on August 28, 2024

go list -m all | nancy works great

from nancy.

DarthHater avatar DarthHater commented on August 28, 2024

@SVilgelm it's more or less just because go.sum files are more like a ledger of what libraries you have used, not what you are currently using. It keeps track of the sha1 of the library, so that if for some reason someone changed a tag upstream etc.... go would be able to tell you, yeah, that's not what you were using before. It provides the mechanism for golang to have deterministic builds, but since it can have old versions of libraries in it, it doesn't provide an accurate look at what you are currently using, which is what go list -m all does. What we'd be removing is just the ability to scan the go.sum file itself, because people could be confused and think they are using something they aren't.

from nancy.

SVilgelm avatar SVilgelm commented on August 28, 2024

but it can really break the current CI scripts. I would recommend to add a deprecation message for a couple of months, then remove

from nancy.

DarthHater avatar DarthHater commented on August 28, 2024

@SVilgelm this is why we are targeting this for v1.0.0 and not in the current v0.x.y series. It's functionality will stick around for v0.x.y releases, which will be mostly patch and no new functionality, but removed from the v1.0.0 forward, so that people can gradually migrate :)

from nancy.

bhamail avatar bhamail commented on August 28, 2024

go.sum is gone. Fixed by #161

from nancy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.