'Invalid recurring shipping method.' and new WC Subscriptions v2.0.14 about woocommerce-subscribe-all-the-things HOT 7 CLOSED

@thenbrent Not sure what might be going on here after looking at Subs code a couple times. Inline doc of class-wc-subscriptions-cart.php is OK, but I'm missing some background that I'd need to be fully able to grasp the underlying logic (or, better, which part of it fails).

from woocommerce-subscribe-all-the-things.

@franticpsyx yeah, we do some pretty crazy things with recurring shipping from v2.0.12 onwards in Subscriptions, and shipping gets really complicated, so I want to save you going down that rabbit hole!

I've assigned this one to me so will tackle it. For reference, it would have been introduced with https://github.com/Prospress/woocommerce-subscriptions/pull/1358

from woocommerce-subscribe-all-the-things.

@shadimanna if you have a site you can easily test v2.0.14 on again, would you mind updating again to v2.0.14 and then changing line 258 of woocommerce-subscriptions/includes/class-wc-subscriptions-cart.php from:

// Keep a record of the shipping packages so we can add them to the global packages later
self::$recurring_shipping_packages[ $recurring_cart_key ] = WC()->shipping->get_packages();

To:

// Keep a record of the shipping packages so we can add them to the global packages later
if ( 0 != $recurring_cart->next_payment_date ) {
    self::$recurring_shipping_packages[ $recurring_cart_key ] = WC()->shipping->get_packages();
}

And letting us know if that fixes it?

That fix is from a separate, but possible related, issue (https://github.com/Prospress/woocommerce-subscriptions/pull/1404).

from woocommerce-subscribe-all-the-things.

@thenbrent In case it helps, I'm also getting a PHP Notice: Undefined index: every_2nd_month_0 in /wp-content/plugins/woocommerce-subscriptions/includes/class-wc-subscriptions-cart.php on line 1070

I've assigned this one to me so will tackle it.

Ops, sorry, just noticed. Dived straight to the code as soon as I saw the notification.

from woocommerce-subscribe-all-the-things.

@thenbrent I tried your fix but it still seems to be happening. Do you want me to give you access to the staging site so you can take a look? If not let me know and I can test another fix.

from woocommerce-subscribe-all-the-things.

@shadimanna that would be a great help. Please email temp admin creds to [email protected]. 😄

from woocommerce-subscribe-all-the-things.

We’ve now fixed this issue in Subscriptions. The PR with the fix here: https://github.com/Prospress/woocommerce-subscriptions/pull/1404 (for those with access to the repo).

We plan to release that this week in a version 2.0.15. Closing this one now. Thanks for the report and help @shadimanna. 😄

from woocommerce-subscribe-all-the-things.