`create-solid` does not support monorepo with yarn workspaces and hoisted deps about solid-start HOT 4 CLOSED

Holy crap I figured it out!!!!!!!!!!!!!!!!!!!!!!!! 🎉 🎊 🥳 🎉 🥳

Or rather, I have a solution. To try to figure out what was going wrong, I compared the results of running solid-start dev in a regular repo vs the monorepo. I noticed that, in the regular repo, three dependencies were being pre-bundled solid-js/web, solid-js, and solid-js/dev but, in the monorepo, only two dependencies were being pre-bundled solid-js/web, solid-js/dev.

Adding solid-js to the vite config's optimizeDeps.include array got the monorepo to pre-bundle solid-js/web, solid-js, and solid-js/dev just like in the regular repo and it eliminated the warning that there were multiple instances of solid-js. It also finally got the default start page to load in a browser. Unfortunately, it was clear something was still going wrong as reactivity on the webpage wasn't working and the page styles hadn't loaded. A console error indicated that

<script
  type="module"
  src="/node_modules/solid-start/runtime/entry.jsx"
></script>

in index.html was failing to load. I realized this made sense, because the dev server root was the project root rather than the workspace root (and solid-start was installed in the workspace root). I tried changing the module link to

<script
  type="module"
  src="../../node_modules/solid-start/runtime/entry.jsx"
></script>

But I discovered that the dev server couldn't load anything outside its root. However, by symlinking the solid-start package in the workspace root's node_modules into the project root's node_modules, then the dev server was able to load the code without issue and everything started working.

Edit:
Rather than symlinking, another option is to specify that the solid-start package should not be hoisted to the workspace root.

I should be able to put together a PR for this in a day or two.

from solid-start.

Anyyone familiar could use help here. There needs to be a single copy of Solid if used in the same app. That requirement cannot change and is true of most frameworks so have no idea why these workspace technologies seem to be defaulting otherwise.

from solid-start.

Upon further inspection, the issue appears to be that vite is caching build artifacts in a special node_modules/.vite folder. In this case, build artifacts include solid-js/dev, solid-js/web, and chunk-A... modules. The chunk-A... module includes its own

var DEV;
{
  DEV = {
    writeSignal,
    serializeGraph
  };
}
if (globalThis) {
  if (!globalThis.Solid$$)
    globalThis.Solid$$ = true;
  else
    console.warn("You appear to have multiple instances of Solid. This can lead to unexpected behavior.");
}

This is currently my best guess to explain how a second copy of solid-js is being created when only one version is installed. Unfortunately, following vite's instructions to disable build dependency caching (optimizeDeps.exclude) and test if that fixes the problem does not seem to work.

from solid-start.

That requirement cannot change and is true of most frameworks so have no idea why these workspace technologies seem to be defaulting otherwise.

It should be noted that the workspace only installs a single version of solid-js, so something else appears to be going wrong. In this case, it looks like the current vite build setup is the culprit (see above).

from solid-start.