Comments (3)
I'm sorry, seeing the issue only now. I'll check this out tomorrow and see where that takes me. Thanks!
from rollup-preset-solid.
Okay, so... thinking a bit more ahead of things, why would we support commonjs?
In most libraries I built with this rollup wrapper, I just set my "type": "module"
in my package.json
and then just export solid
and default
. Here's an example with solid-heroicons
: https://github.com/amoutonbrady/solid-heroicons/blob/master/package.json#L6-L21
If I wanted to go a step further I could additionally add a difference between node build and browser build but is the esm / cjs serparation really necessary?
from rollup-preset-solid.
"type": "module"
isn't currently widely adopted by most packages and so it breaks most of the interoperability with those packages, the most affected being the tools (i.e. eslint, postcss, jest, babel, etc.). Shipping CJS/ESM for packages is currently the most widely accepted form of distribution.
Also do take note that this opinion was also based on a lot of user feedbacks for solid-app-router
and solid-start
as I recall
from rollup-preset-solid.
Related Issues (10)
- Split dist/esm in multiple files HOT 2
- Does not handle imports with iife output format
- ES module load error HOT 1
- Export using `.cjs` / `.mjs` extensions HOT 1
- Libraries built with this preset don't work in Astro HOT 3
- Not working with jsx import extensions
- MIT license? HOT 2
- Override `input` and `output` HOT 2
- Waring for .js instead of .isx input
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rollup-preset-solid.