Git Product home page Git Product logo

Comments (25)

github-actions avatar github-actions commented on September 16, 2024

This Feature Request was accepted and is ready for specfication.

from seliproject.

ecureuill avatar ecureuill commented on September 16, 2024

@juantenesaca @CAndresH I finished the specification for Report step and the Accessibility validation

from seliproject.

ecureuill avatar ecureuill commented on September 16, 2024

@CAndresH I just updated the table with the validation by components.
In case of PDF (#149), each accessibility resource has a related issue that is labeled with the impacted disabilities

image

from seliproject.

CAndresH avatar CAndresH commented on September 16, 2024

Hi, a question: Where on the platform should this option go?
If teacher click on a Topic Name, system should ask if teacher wants to go to the topic ( Program Step) to fix the accessibility problems

from seliproject.

ecureuill avatar ecureuill commented on September 16, 2024

Sorry @CAndresH, I didn't see your comment before.

In report, system will show accessibility progress by topi/unit in the "Topics" section. Each topic/unit should be clickable

from seliproject.

CAndresH avatar CAndresH commented on September 16, 2024

from seliproject.

caroltaus avatar caroltaus commented on September 16, 2024
  • For an image to be considered decorative the user has to check it twice

here:
image

and here:
image

it would be better to delete this second check box


  • These could be shown in a 2x2 grid and the icons could be centralized to the text

image


  • The "You have achieved you inclusion goal" text should not appear when the user did not select any inclusion goal

image


  • Some accessibility configurations result in error in the percentage calculation

image


  • For some accessibility configurations even when ALL inclusion goals are selected only 2 (of 4) gauges are shown in the report

All inclusion goals selected:
image
Only Hearing and Cognitive gauges are shown
image


  • All gauges could be the same size

image

from seliproject.

CAndresH avatar CAndresH commented on September 16, 2024

Hi Caroline, could you tell me what settings you put in the course Plan to get those errors?

from seliproject.

caroltaus avatar caroltaus commented on September 16, 2024

@CAndresH
Hi! Yes, this was the configuration in Course Plan
image
guided + toybox

from seliproject.

caroltaus avatar caroltaus commented on September 16, 2024
  • Accessibility is not being validated for decorative images

when the user configures it:
image

it's still shown as inaccessible:
image

when user clicks to edit its accessibility the system shows a required text field that shouldn't exist for decorative images:
image


  • Nan Percentage is still appearing for some configurations, here are some:
    In Course Plan guided + toybox and will all Inclusion Goals selected

1 - with only one video, and its accessibilities configurations ALL accessible EXCEPT for audio description
image

Accessibility Report:

image

2- with only one audio, and completely INACCESSIBLE
image

Accessibility Report:
image

when you configure 1 out of 2 accessibility:
image

Accessibility Report:
image

from seliproject.

CAndresH avatar CAndresH commented on September 16, 2024

Hi Caroline,

Could you now check the reports part and tell me if there are the same errors?
Thank you

from seliproject.

caroltaus avatar caroltaus commented on September 16, 2024

@CAndresH
The NaN error is fixed for these situations! Thank you!

from seliproject.

caroltaus avatar caroltaus commented on September 16, 2024
  • When user is on GUIDED mode there should not appear a Syllabus Accessibility Report, since the plataform is making the syllabus (already accessible)

image
image


  • When a type of accessibility is at 100% accessible the plataform should show the icons, instead of gauges

how it is:
image

icons that should appear instead of the gauges:
image

from seliproject.

CAndresH avatar CAndresH commented on September 16, 2024

Hi Caroline, is this part "When a type of accessibility is at 100% accessible the platform should show the icons, instead of gauges", what I understood from Camila's demo is that when you do not select the audiences, the percentages should appear with the graphs and when you select the audiences (in audience step) and they are accessible 100%, then the green icons should appear,

Maybe I misunderstood, in which case I can change it, could you please confirm this with Camila?

from seliproject.

caroltaus avatar caroltaus commented on September 16, 2024

@CAndresH
Just talked to Camilla, she said it's okay to keep it as it is right now! Sorry for the confusion!

from seliproject.

ecureuill avatar ecureuill commented on September 16, 2024

Report is presenting wrong data

  • Not reporting "not configured" items (scenario 1)
  • Wrongly reporting "misconfigured" items (scenario 1)
  • Wrongly reporting multiple topics (scenario 2)

Scenario 1: Steps to Reproduce

  1. Select Visual Disability in Audience Step
  2. Add 1 topic in Design Step
  3. Add 4 Images of type "Informative" with accessibility "well configured" (Image 1)
    1. Go to Report step and check that "You have achieved your Inclusion Goal" is presented with Visual Disability logo
  4. Add 1 image and select to configure accessibility later
    1. Go to Report step and check that, despite there is 1 not configured accessibility, the same status of 3.i is presented (wrong)
  5. Select to configure accessibility of the image lacking configuration
    1. Set the image as "Informative" and save it without informing a text alternative
    2. Go to Report step and check that, despite there is 1 misconfigured accessibility, is reported that there is 1 TO-DO and 1 NOT ACCESSIBLE (wrong)

Expected Result:

  • step 4 should report 1 TO-DO and 0 NOT ACCESSIBLE
  • step 5 should report 0 TO-DO and 1 NOT ACCESSIBLE

Image 1
image 1

Steps to Reproduce

  1. Select Visual Disability in Audience Step
  2. Add 1 topic in Design Step
  3. Add 5 Images of type "Informative" with accessibility "well configured" (Image 1)
    1. Go to Report step and check that "You have achieved your Inclusion Goal" is presented with Visual Disability logo
  4. Go back to Design Step and add 1 more topic
    1. Go to Report step and check that presents:
      1. 5 Done; 0 To-do; 0 Not accessible
      2. overall accessibility progress is 50% (wrong)
      3. Go to Report step and check that Topic 1 accessibility progress is 100%
      4. Go to Report step and check that Topic 2 accessibility progress is 0% (wrong)
  5. Go back to Program Step and add 1 text component in Topic 2 (or any component with no accessibility settings option)
    1. Go to Report step and check that presents (image 2a and image 2b):
      1. 5 Done; 0 To-do; 0 Not accessible
      2. overall accessibility progress is 50% (wrong)
      3. Go to Report step and check that Topic 1 accessibility progress is 100%
      4. Go to Report step and check that Topic 2 accessibility progress is 0% (wrong)
  6. Go back to Program Step and add 1 audio component in Topic 2 and do not configure accessibility
    1. Go to Report step and check that presents:
      1. 5 Done; 0 To-do; 0 Not accessible
      2. overall accessibility progress is 50% (wrong)
      3. Go to Report step and check that Topic 1 accessibility progress is 100%
      4. Go to Report step and check that Topic 2 accessibility progress is 0% (wrong)
  7. Go to Program Step and add 1 video component in Topic 2 and do not configure accessibility
    1. Go to Report step and check that presents:
      1. 5 Done; 0 To-do; 0 Not accessible (wrong)
      2. overall accessibility progress is 50% (wrong)
      3. Go to Report step and check that Topic 1 accessibility progress is 100%
      4. Go to Report step and check that Topic 2 accessibility progress is 0%
  8. Go back to Program Step and add 3 images component in Topic 2: misconfigure the first as COMPLEX IMAGE, do not configure the second and well configure the third as COMPLEX IMAGE (Image 3)
    1. Go to Report step and check that "You have achieved your Inclusion Goal" is presented with Visual Disability logo (wrong) (the report now is showing a different status, but yet wrong):
      • 7 Done;
      • 1 To-do; (wrong)
      • 1 Not accessible (wrong)
      • overall accessibility progress is 55% (wrong)
      • Go to Report step and check that Topic 1 accessibility progress is 100%
      • Go to Report step and check that Topic 2 accessibility progress is 17% (wrong)

Expected Result:

  • step 4 should report same as 3.i. As I just added 1 topic with no content it should not affect accessibility status
  • step 5 should report same as 3.i As I just added a component that there is no accessibility settings, it should not affect accessibility status
  • step 6 should report same as 3.i As I just add a component that there is no accessibility settings related to VISUAL DISABILITY, it should not affect accessibility status
  • step 7 should report: As I just added a component that its accessibility settings are partially related to VISUAL DISABILITY, those accessibility settings options that are related to VISUAL DISABILITY should affect accessibility status
    - 5 Done;
    - 3 To-do;
    - 0 Not accessible
    - overall accessibility progress is 75% (5/8)
    - Topic 1 accessibility progress is 100% (5/5)
    - Topic 2 accessibility progress is 0% (0/3)
  • step 8 should report:
    - 7 Done; 5 images from Topic1 and 1 image from Topic2 (2 options)
    - 4 To-do; 1 video (3 options) and 1 image from Topic 2
    - 2 Not accessible 1 image from Topic 2 (2 options)
    - overall accessibility progress is 46,15% (6/13)
    - Topic 1 accessibility progress is 100% (5/5)
    - Topic 2 accessibility progress is 12,5% (1/8)

The course I created to test
https://vm2161.kaj.pouta.csc.fi/coursePreview#Ctz4PCgxG2nGrXR9G

Image 2a
image 2a
Image 2b
image

Image 3a
image
Image 3b
image

from seliproject.

ecureuill avatar ecureuill commented on September 16, 2024

Bugs that blocks the use of this feature or generates wrong data

from seliproject.

ecureuill avatar ecureuill commented on September 16, 2024
  • need to fix #11

This bugs could generate wrong datas

from seliproject.

CAndresH avatar CAndresH commented on September 16, 2024

Hello everyone, just review the features that camila has put in the comments and comment if there is any error,

This tool is not finished and there may still be some errors, but I am going to stop making changes in this part for the moment, to dedicate time to other, higher priority requirements,

from seliproject.

ecureuill avatar ecureuill commented on September 16, 2024

This tool is not finished and there may still be some errors, but I am going to stop making changes in this part for the moment, to dedicate time to other, higher priority requirements,

Ok, @CAndresH I added the label blocked and when you resume the development, just remove it.

from seliproject.

github-actions avatar github-actions commented on September 16, 2024

This feature have been implemented and is ready for Funcional Test.
Please, test the feature.

from seliproject.

github-actions avatar github-actions commented on September 16, 2024

Functional Test failed!
Please, review your solution.


Task from requirement has not been done:
image

For example:
When I select hearing disabilities as an inclusion goal, when I configure the accessibility for video/audio the text transcription should have a "(Required for inclusion)" in its visible label

image
image
image

from seliproject.

CAndresH avatar CAndresH commented on September 16, 2024

@rebeccamello @caroltaus according to the meeting now the label "(Required for inclusion)" is static for all the audiences that involves text

from seliproject.

github-actions avatar github-actions commented on September 16, 2024

This feature have been implemented and is ready for Funcional Test.
Please, test the feature.

from seliproject.

github-actions avatar github-actions commented on September 16, 2024

Functional Test passed!
Please, make a PULL REQUEST or, if already merged, close the issue.

from seliproject.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.