Use SDL_HWSURFACE (or at least, use the same flag everywhere) about solarus HOT 3 CLOSED

At your opinion, what is the best way to provide VideoManager::surface_flags access inside Color and Surface class ?

I thought make them friend class or just add a getter, but I don't like both.
Include VideoManager just to read a constant value is not really ideal...

Can we define this flag directly in Common.h, or you don't want to handle lib-specific stuff in this file ?

from solarus.

If I understand correctly, Color and Surface should use SDL_SWSURFACE in all cases and for any OS.
Commit acb4242 should solve this issue. Color and Surface always use SDL_SWSURFACE now (no matter the OS).

And VideoManager sets its own flags depending on the SOLARUS_SCREEN_SOFTWARE_SURFACE preprocessor constant: surface flags is SDL_HWSURFACE | SDL_DOUBLEBUF or SDL_SWSURFACE.

Is this okay for you?

from solarus.

Yep :)

The big thing I wanted to point is mainly to use SDL_SWSURFACE on surfaces which are locked even once during loop turn.

from solarus.