Comments (3)
At your opinion, what is the best way to provide VideoManager::surface_flags access inside Color and Surface class ?
I thought make them friend class or just add a getter, but I don't like both.
Include VideoManager just to read a constant value is not really ideal...
Can we define this flag directly in Common.h, or you don't want to handle lib-specific stuff in this file ?
from solarus.
If I understand correctly, Color and Surface should use SDL_SWSURFACE in all cases and for any OS.
Commit acb4242 should solve this issue. Color and Surface always use SDL_SWSURFACE now (no matter the OS).
And VideoManager sets its own flags depending on the SOLARUS_SCREEN_SOFTWARE_SURFACE preprocessor constant: surface flags is SDL_HWSURFACE | SDL_DOUBLEBUF or SDL_SWSURFACE.
Is this okay for you?
from solarus.
Yep :)
The big thing I wanted to point is mainly to use SDL_SWSURFACE on surfaces which are locked even once during loop turn.
from solarus.
Related Issues (20)
- enemy:on_custom_attack_received(attack, enemy_sprite) does not allow to call enemy:hurt() HOT 3
- Game performance drops when lots of sprites are displayed HOT 2
- Compilation fails on systems without OpenGL 3 or ES
- Create multiple playable character HOT 1
- Animation "sword" for shield sprite is wrong HOT 1
- Héros non ralenti dans les terrains "eau peu profonde" / Speed problem in shallow water
- Deprecate enemy:on_collision_enemy()
- Add new events on_map_finished and on_opening_transition_finished HOT 2
- Entity still drawn after it was removed
- Invalid PNG causes game to crash without an error HOT 1
- Ennemis ne meurent pas vraiment
- Add autosave HOT 1
- Nouvelle fonction item:set_pickable_by_sword() HOT 3
- Separate shader code from shader data file
- Separate shader code from shader data file
- Add Lua methods to create shaders from GLSL source
- Add a method to know if the hero is currently on an active stream HOT 1
- Allow to launch .solarus directly
- Sprite method fade_in not working after calling fade_out
- Add collision mode of "ground" type
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from solarus.