Git Product home page Git Product logo

Comments (6)

mvines avatar mvines commented on July 2, 2024

I continue to hate decimals a lot...

from solana-program-library.

mvines avatar mvines commented on July 2, 2024

Problem: Transfer and MintTo's ability to overwrite the destination token account item value could be use to attack empty wallets. Token accounts probably need to indicate they're willing to accept any item, possibly as an argument into InitializeAccount

from solana-program-library.

mvines avatar mvines commented on July 2, 2024

Another path:

  1. SFTs are really just FTs. The benefit of the proposal above is that SFTs of the same "collection" can share a Mint. Maybe that's not a big deal, especially if the Mint receives a URL/address to additional metadata.
  2. NFTs are a different program: spl-item or spl-unique-item perhaps. Very similar setup as spl-token but with some complexity removed. In this scenario NFTs of the same "collection" can still share a Mint. (I strongly dislike the approach of NFTs being represented as a spl-token with just one account, seems wasteful and too difficult for clients to find all the NFTs of the same collection)

This pushes more complexity onto the client than the above proposal.

from solana-program-library.

CriesofCarrots avatar CriesofCarrots commented on July 2, 2024
I strongly dislike the approach of NFTs being represented as a spl-token with just one account

I don't quite follow what the alternative is. An account that can hold multiple NFTs from a collection?

too difficult for clients to find all the NFTs of the same collection

Isn't this the same as finding the total supply of a fungible Mint?

from solana-program-library.

mvines avatar mvines commented on July 2, 2024

I don't quite follow what the alternative is. An account that can hold multiple NFTs from a collection?

Say there's an spl-item program with a Mint and Account like spl-token has. The Account here doesn't hold an amount. It probably only has a SetOwner-like instruction as well, to transfer ownership of that NFT to another user.

Isn't this the same as finding the total supply of a fungible Mint?

That's a little different to me. Without a common Mint to try all the NFTs together in a collection, it's hard to be able to find all the hockey cards or my little ponies. You can't tell what's a card and what's a horse.

from solana-program-library.

mvines avatar mvines commented on July 2, 2024

Nope, not going to pursue this approach. The item brings baggage to the world of fungible tokens. We can do better

from solana-program-library.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.