Comments (5)
soheilhy
commented on July 21, 2024
1
Thanks for the confirmation.
from cmux.
soheilhy
commented on July 21, 2024
That's odd. I will have to take a look. Does your SSH connection send the
HTTP2 preface?
…On Fri, Apr 21, 2017 at 1:08 PM, Florian Bertholin ***@***.*** > wrote:
Hi,
I'm trying to use cmux to serve gRPC + SSH connections, but I cannot make
it works.
lis, _ := net.Listen("tcp", ":8080")
l := cmux.New(lis)grpcL := l.Match(cmux.HTTP2HeaderField("content-type", "application/grpc"))sshL := l.Match(cmux.Any())
It serves gRPC well but it blocks when I connect with a ssh client.
If I comment the gRPC Match the SSH connections work. Am I doing
something wrong?
Thanks
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#44>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAYGhT5ZopypI92zlHuKuWhN2mDITSo9ks5ryOKlgaJpZM4NEjw3>
.
from cmux.
arkan
commented on July 21, 2024
Hey, thanks for the reply!
Here is what I have if I run the SSH command with -v:
$> ssh -v -p 8081 127.0.0.1
OpenSSH_7.4p1, LibreSSL 2.5.0
debug1: Reading configuration data /Users/arkan/.ssh/config
debug1: /Users/arkan/.ssh/config line 1: Applying options for *
debug1: Reading configuration data /etc/ssh/ssh_config
debug1: Connecting to 127.0.0.1 [127.0.0.1] port 8081.
debug1: Connection established.
debug1: identity file /Users/arkan/.ssh/id_rsa type 1
debug1: key_load_public: No such file or directory
debug1: identity file /Users/arkan/.ssh/id_rsa-cert type -1
debug1: Enabling compatibility mode for protocol 2.0
debug1: Local version string SSH-2.0-OpenSSH_7.4
And then the connection is blocked. If you need anything else let me know.
from cmux.
soheilhy
commented on July 21, 2024
I think this is a cmux bug. Can you please try branch fix-44 to see if it fixes your issue and doesn't cause any other regressions for you? Thanks!
https://github.com/soheilhy/cmux/tree/fix-44
from cmux.
arkan
commented on July 21, 2024
Hey, I tried it out on my project and it seems to be working as expected :)
Thanks for the patch.
from cmux.
Related Issues (20)
- Upgrade the x/net version in dependencies?
- metrics for mux usage
- cmux is not usable with GRPC+TLS
- Add benchmarks
- badly-behaved client can deadlock server stopping HOT 3
- Cannot get Matchers to mux h2c gRPC and HTTP2(REST) requests HOT 4
- It's hard to extend protocol HOT 3
- how to write client codeto gprc connect HOT 2
- Doesn't work with grpc-go's hello world example HOT 2
- Pull In Downstream Fixes HOT 1
- Cannot check closed error with errors.Is HOT 1
- Multiplexing gRPC and Prometheus metrics services using Google Cloud Run
- Matching based on URL HOT 1
- Cmux example HOT 1
- Close not working properly on gRPC graceful stop HOT 1
- Multiplexing gRPC & HTTP handlers with H2C+Prior Knowledge HOT 4
- socks5 matcher not working HOT 2
- http2 matcher not working with net/http HOT 2
- I don't understand why calling source.Read() might block?
- HTTP1Fast matcher omits PATCH HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cmux.