Comments (9)
No, you are right, somehow the + is not escaped correctly. I'll take a look tomorrow.
from sttp.
Hmm I suppose we'll need context-sensitive decoding, not only encoding, wich makes sense :) The +
in the query string should be converted to a
(space), but not in the path
from sttp.
By query string, do you mean the named URI parameters? Actually my use case is a URI as follows:
http://localhost:8081/user?phone=+123456
The context is looking up by phone that is. Come to think about it, "+" is really used as a space in this context. However, does it make sense to still have it as a space in sttp? After all, you can perfectly use spaces in query string and they will be encoded properly.
from sttp.
If you want to include +
in the query string, it should be %-encoded, as +
is the escaped form of space (in that context).
The interpolator assumes that when you write down a literal URI (as a String
, without embedding any expressions), it's in encoded form - hence it decodes any special characters. So:
uri"http://localhost:8081/user?phone=+123456"
will be parsed as an URI with a single query parameter phone
with the value 123456
uri"http://localhost:8081/user?phone=${"+123456"}"
will be parsed as an URI with a single query parameter phone
with the value +123456
from sttp.
Hm, then this does not seem to be working with get
requests (maybe also with others). When I do:
sttp.get(uri"http://localhost:8888/appointment?phone=${"+1234"}").send()
And on the server side (http4s):
val root = Root / "appointment"
/*...*/
case req @ GET -> `root` :? PhoneParam(phoneRaw) =>
println(s"Raw request parameter: $phoneRaw")
This prints:
Raw request parameter: 1234
from sttp.
Ah, come to think about it this may be http4s issue.
from sttp.
I think it's an easy fix (only the +
is problematic), see the commit. I'm publishing a snapshot (for some reason it gets published as 0.0.20-SNAPSHOT), but the release will definitely have to wait until tomorrow ;)
from sttp.
Awesome, thank you for the quick fix @adamw! I will check it out tomorrow.
from sttp.
Released 1.0.6
from sttp.
Related Issues (20)
- Add support for play-json 3 HOT 1
- Update to Prometheus 1.x.x HOT 3
- [BUG] HEAD request times out using Http4s backend HOT 2
- Http proxy problem with async-http-client-backend-zio:3.9.1
- Uri interpolation incorrectly percent-encodes some characters HOT 2
- where is basicRequest? HOT 1
- AbstractFetchBackend does not support manual cancellation/interruption
- Expose AsyncHttpClient when creating AsyncHttpClientBackend HOT 2
- Preserve request-metadata in SttpBackendStub HOT 2
- is `null` valid header field value? HOT 5
- Integrate oauth? HOT 16
- add support Tethys json HOT 2
- Add Scala 3 support for play-json HOT 4
- quickRequest: Unexpected behaviour dependent on method order HOT 4
- Refactor metrics names according to standards
- Metrics caching rework
- No json4s release for scala 3 HOT 4
- Add Ox integration: SSE & WebSockets? HOT 2
- Spray json support for scala 3 HOT 3
- enable logback logging for sttp 1.7.x HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sttp.