Git Product home page Git Product logo

Comments (4)

chunghe avatar chunghe commented on April 27, 2024 1

i've created a very simple script to solve this: https://gist.github.com/chunghe/8472c99f12beaf93fef41f30e7338d62

Replace the parser above written in Regex with svg-path-parser which is more robust and works perfectly.

from react-native-svg.

magicismight avatar magicismight commented on April 27, 2024 1

@chunghe
I don`t think 3rd-party parser is necessary.
I had fixed this by fixing the float RegExp.

.replace(/(\.\d+)(?=\-?\.)/ig, '$1,')

from react-native-svg.

chunghe avatar chunghe commented on April 27, 2024

I think this bug is in following lines:

https://github.com/magicismight/react-native-svg/blob/6ccb9058fec65d35524c874b0f2040855ad9a875/lib/SerializablePath.js#L20

the minimum code to reproduce:

"c.202.187.306.432.312.68"
  .replace(/(\.[\d]+)(\-?\.)/ig, '$1,$2')  // "c.202,.187.306,.432.312,.68"
  .match(/[a-df-z]|[\-+]?(?:[\d\.]e[\-+]?|[^\s\-+,a-z])+/ig); // ["c", ".202", ".187.306", ".432.312", ".68"]

after parsing, the array contains two points like '.187.306' which cannot covert to a number.

Hope that's helpful.

from react-native-svg.

chunghe avatar chunghe commented on April 27, 2024

@magicismight i'm not sure using 3rd-party svg path parser is the way you want to go, if yes, i could try to come up with the pull request.

from react-native-svg.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.