Git Product home page Git Product logo

Comments (8)

tjzel avatar tjzel commented on July 19, 2024 5

3.12.1 containing the fix is out!

from react-native-reanimated.

tjzel avatar tjzel commented on July 19, 2024 2

No, that's actually not the case here. I'd normally release it in a patch immediately, but I had some reasons regarding the changes in our repo structure that made me postpone it.

However, when I went over them right now it turns out they are actually invalid. I will try to publish the patch later today 😃

from react-native-reanimated.

github-actions avatar github-actions commented on July 19, 2024

Hey! 👋

It looks like you've omitted a few important sections from the issue template.

Please complete Snack or a link to a repository section.

from react-native-reanimated.

github-actions avatar github-actions commented on July 19, 2024

Hey! 👋

The issue doesn't seem to contain a minimal reproduction.

Could you provide a snack or a link to a GitHub repository under your username that reproduces the problem?

from react-native-reanimated.

kirillzyusko avatar kirillzyusko commented on July 19, 2024

@tjzel just discovered that it looks like it has been fixed in #6098 right?

May I kindly ask you to prepare a new patch release for 3.12? (3.12.1 I guess) 🙏 I think it's a very critical one 😓

I see that fix was published under 3.13 RC, but I think this issue may affect many projects, that's why I'm asking to prepare a hotfix release. I hope it makes sense what I'm saying 😅

from react-native-reanimated.

tjzel avatar tjzel commented on July 19, 2024

Yeah, I think that's a reasonable request. We released it in an RC version because I'm not absolutely certain it works in all scenarios. Have you tried the RC release to see if it works for you?

from react-native-reanimated.

tjzel avatar tjzel commented on July 19, 2024

Duplicate of #6066

from react-native-reanimated.

kirillzyusko avatar kirillzyusko commented on July 19, 2024

Have you tried the RC release to see if it works for you?

@tjzel No, not yet. But it was in my To Do list 🙃

Though it's worth to note, that I created a patch from your PR and it fixed a problem in my case (but I haven't tested a new RC yet).

We released it in an RC version because I'm not absolutely certain it works in all scenarios.

Well, even if it works not in all scenarios, then later on you can release a new version with additional fixes 😁

I understand, that you want to keep as small as possible releases and don't publish an official release for each new important bug fix, but this commit is actually very important, because it break a compatibility with all old versions (basic functionality works for sure, but I think many people were relying on capturing external objects in closures) 😔

from react-native-reanimated.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.