Git Product home page Git Product logo

Comments (8)

pfeiffer avatar pfeiffer commented on June 29, 2024 2

We are using an older version from last year in production, so it is indeed working. However, it is a bit problematic and unpredictable to use the main branch in production. Do you plan on tagging a stable release anytime soon @pfeiffer?

Yup, I expect at least an initial "stable" version will be available soon™️ :-)

from react-native-turbo-demo.

pfeiffer avatar pfeiffer commented on June 29, 2024

Hey! We're sponsoring the maintainer's development of this package and using it in an almost complete app, so I can confirm that it indeed is working. The app is relatively complex in terms of navigation patterns and uses Strada components to handle a lot of native features (IAP, Push etc.), so it's definitely feasible to get a proper working app.

We're extracting a lot of the changes and fixes that we've made back into the library as we go. For now, using the main branch is recommended; the released packages are not stable.

We've found that Turbo Native (be that the native iOS or Android or the React Native implementation) requires some customization the Rails side as well; we're considering releasing those customizations as a gem or at least wrap up a wiki/blog that outlines those changes. To name a few examples is to use the "magic" URL redirects (recede_historical_location, ..) from Turbo as well as customize redirection behaviors quite a bit, so that every redirect_to .. redirects by outputting a HTML page that triggers Turbo.visit(..), as otherwise the Turbo Native libraries are not able to properly handle redirects.

from react-native-turbo-demo.

cspeer avatar cspeer commented on June 29, 2024

Hi @pfeiffer ,

thanks for the speedy reply.

Yes, I'm currently using these commits in my package.json:

"react-native-turbo": "https://gitpkg.now.sh/software-mansion-labs/react-native-turbo-demo/packages/turbo?e5a61f5ada83c7cdae1e3ce7b56411cda6c0bb8f",
"react-native-web-screen": "https://gitpkg.now.sh/software-mansion-labs/react-native-turbo-demo/packages/navigation?e5a61f5ada83c7cdae1e3ce7b56411cda6c0bb8f",

Would you recommend I use a different commit?

from react-native-turbo-demo.

antonborgstrom avatar antonborgstrom commented on June 29, 2024

I agree, very grateful for the hard work you are putting into this project! Good job!

We are using an older version from last year in production, so it is indeed working.
However, it is a bit problematic and unpredictable to use the main branch in production.
Do you plan on tagging a stable release anytime soon @pfeiffer?

from react-native-turbo-demo.

pfeiffer avatar pfeiffer commented on June 29, 2024
"react-native-turbo": "https://gitpkg.now.sh/software-mansion-labs/react-native-turbo-demo/packages/turbo?e5a61f5ada83c7cdae1e3ce7b56411cda6c0bb8f",
"react-native-web-screen": "https://gitpkg.now.sh/software-mansion-labs/react-native-turbo-demo/packages/navigation?e5a61f5ada83c7cdae1e3ce7b56411cda6c0bb8f",

Would you recommend I use a different commit?

We're using these for the time being:

"react-native-turbo": "https://gitpkg.now.sh/software-mansion-labs/react-native-turbo-demo/packages/turbo?193c1c6",
"react-native-web-screen": "https://gitpkg.now.sh/software-mansion-labs/react-native-turbo-demo/packages/navigation?193c1c6",

.. bumping these as we land new patches to the main branch.

from react-native-turbo-demo.

cspeer avatar cspeer commented on June 29, 2024

Thanks a lot @pfeiffer. Very much looking forward to a (somwhat) stable release!
Would you mind sharing your package.json? I'm now using the above mentioned commits but am still running into exceptions, the latest of which is

TypeError: Cannot read property 'getSessionHandles' of null, js engine: hermes

So, taking a look at the other packages, especially the react-native one, would be great. Thanks!

from react-native-turbo-demo.

pfeiffer avatar pfeiffer commented on June 29, 2024

That sounds to me like a missing pod install? We're using Expo SDK 50, eg:

"expo": "~50.0.7",
"react-native-turbo": "https://gitpkg.now.sh/software-mansion-labs/react-native-turbo-demo/packages/turbo?193c1c6",
"react-native-web-screen": "https://gitpkg.now.sh/software-mansion-labs/react-native-turbo-demo/packages/navigation?193c1c6",
"react-native": "0.73.4",

and building via npx expo run:ios.

I've seen from time to time that using the packages via gitpkg can cause some inconsistencies, in that case I typically remove both the node_modules folder and ios/android folders and refetch all dependencies via yarn install and do a clean Expo build using the above command.

from react-native-turbo-demo.

cspeer avatar cspeer commented on June 29, 2024

It's finally working!
I think the problem was a whole bunch of outdated expo packages and probably an older node version. I've been trying to get it to work in my existing project, so lots of legacy code and packages.
Thanks a bunch @pfeiffer!

from react-native-turbo-demo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.