retryCount not incremented when using custom retryCondition about axios-retry HOT 6 CLOSED

My guess is that your retryCondition should check for a 429 status as a number:

error.response.status === 429

from axios-retry.

Ill give it a go but if retryCondition fails, it wont even get into retryDelay so not sure how that will help. To be clear, the issue is that when I am in the retryDelay callback, retryCount is never incremented.

To me the issue is that the logic to increment retryCount is caught up in the default retryCondition callback and is not called when a custom callback is used.

from axios-retry.

I have been seeing issues where neither retry count or retry delay are respected. I had upgraded to axios 0.19.0 within the last week, so I suspected that. Sure enough, when I downgraded back to 0.18.0, the axios-retry went back to working as it should. I will try to file a bug report later for this incompatibility where I can properly display the evidence.

from axios-retry.

Could what you describe be a duplicate of #59 ?

from axios-retry.

@mawrkus Yep, I think you’re right. I didn’t realize the problem would have shown up that long ago in the beta of axios 0.19.0.

@drwharris, can you confirm which version of axios you are using?

from axios-retry.

@danielmcq @mawrkus
COnfirming I was on 0.19. Downgraded to 0.18.1 and its working. And yes, this is exactly the same as #59. Sorry, poor form on my behalf there. Ill close this as you're actively working on that issue.

from axios-retry.