Git Product home page Git Product logo

Comments (4)

mawrkus avatar mawrkus commented on September 3, 2024

Hi!

Have you tried:

function retryDelay(retryNumber = 0) {
  displayRetryMessage();
  const delay = Math.pow(2, retryNumber) * 100;
  const randomSum = delay * 0.2 * Math.random(); // 0-20% of the delay
  return delay + randomSum;
};

function displayRetryMessage(retryNumber) {
  if (retryNumber > 1) return;
  alert('Ooops! We are having some network issues & we are retrying. Thanks for being patient!');
}

axiosRetry(axios, { retryDelay });

or similar?

from axios-retry.

anagrath avatar anagrath commented on September 3, 2024

from axios-retry.

mawrkus avatar mawrkus commented on September 3, 2024

I understand... I've just found out that axiosRetry exposes the static method for the exponential delay, so at the end, you don't have to reimplement it:

import axiosRetry from 'axios-retry';

function retryDelay(retryNumber) {
  displayRetryMessage();
  return axiosRetry.exponentialDelay(retryNumber)
};

function displayRetryMessage(retryNumber) {
  if (retryNumber > 1) return;
  alert('Ooops! We are having some network issues & we are retrying. Thanks for being patient!');
}

axiosRetry(axios, { retryDelay });

Regarding the PR, I'm not an active maintainer of this package but my point of view is that you have added a new optional callback that is called exactly like retryDelay is (receiving the same parameters etc.). Why not just using retryDelay then?

from axios-retry.

anagrath avatar anagrath commented on September 3, 2024

from axios-retry.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.