Unhandled Exception does not stop program running about async HOT 10 CLOSED

For me all problems started with stopping the event loop. There is a trick used by many without OS interrupts. Make a pipe. And select() on the read end of the pipe all the time. And if you want to interrupt, then you write a byte to the write end of the pipe. Maybe it is completely unrelated, but i hope this may help you.

from async.

It is all good.
I am sorry for the false alarm.
This time it was an error on my side. (Sent an exception to the wrong fiber, where there was no exception handling)

from async.

This is probably a bug that can only be fixed by modifying/fixing CRuby.

It's probably in the thread exit code path where a scheduler is set, it's ignoring the exception.

I'll take a look.

from async.

As a bit of a hack, we can define Async::Scheduler#scheduler_close as:

		def scheduler_close
			unless $!
				self.run
			end
		ensure
			self.close
		end

and it works as you expect, but I don't like using the implicit $! exception reference. We should probably pass it explicitly if possible.

from async.

I'm basically okay with the proposed fix, the chance of $! being set incorrectly in the scheduler_close context is probably zero.

from async.

This should be fixed, please feel free to test it and report back.

from async.

Either this fix or the scheduler closing broke exception handling for me:
I can not catch exception any more in Fibers.

/home/jsaak/.gem/ruby/3.2.2/gems/async-2.6.3/lib/async/scheduler.rb:246:in `select': Failed (RuntimeError)
	from /home/jsaak/.gem/ruby/3.2.2/gems/async-2.6.3/lib/async/scheduler.rb:246:in `run_once!'
	from /home/jsaak/.gem/ruby/3.2.2/gems/async-2.6.3/lib/async/scheduler.rb:222:in `run_once'
	from /home/jsaak/.gem/ruby/3.2.2/gems/async-2.6.3/lib/async/scheduler.rb:285:in `block in run'
	from /home/jsaak/.gem/ruby/3.2.2/gems/async-2.6.3/lib/async/scheduler.rb:279:in `handle_interrupt'
	from /home/jsaak/.gem/ruby/3.2.2/gems/async-2.6.3/lib/async/scheduler.rb:279:in `run'
	from /home/jsaak/.gem/ruby/3.2.2/gems/async-2.6.3/lib/async/scheduler.rb:46:in `scheduler_close'
jsaak@auto:[master]~$ curl: (23) Failure writing output to destination
(23) Failed writing body
curl: (23) Failure writing output to destination

After this happens, it hangs. Does not exit.

I do not understand what you are trying to do.

from async.

Do you mind giving me a small reproduction?

from async.

I will try.

from async.

It's all good, let me know if you run into any other issues.

from async.