Git Product home page Git Product logo

Comments (5)

darrachequesne avatar darrachequesne commented on June 11, 2024 2

Awesome, thanks for the update 👍

I've added a note about the publishOnSpecificResponseChannel option here: https://socket.io/docs/v4/redis-adapter/#default-adapter

from socket.io-redis-adapter.

darrachequesne avatar darrachequesne commented on June 11, 2024 1

Hi! You can set publishOnSpecificResponseChannel to true, in that case the Socket.IO servers will use a Redis channel specific to the requesting node to respond (and not publish to all nodes).

from socket.io-redis-adapter.

darrachequesne avatar darrachequesne commented on June 11, 2024 1

Source:

private publishResponse(request, response) {
const responseChannel = this.publishOnSpecificResponseChannel
? `${this.responseChannel}${request.uid}#`
: this.responseChannel;
debug("publishing response to channel %s", responseChannel);
this.pubClient.publish(responseChannel, response);
}

When publishOnSpecificResponseChannel is set to false (default value), the response is sent to all nodes, but only one node is interested by the response (channel name: this.responseChannel).

When publishOnSpecificResponseChannel is set to true, the response is only sent to the requesting node (channel name: ${this.responseChannel}${request.uid}#).

The latter should be the default behavior, as the filtering is done by Redis, but to maintain backward-compatibility the default value is false.

from socket.io-redis-adapter.

Valentinfe avatar Valentinfe commented on June 11, 2024

Thanks for your quick answer !

In your point of view what are the pros/cons of both options ? We will use socket.io and this adapter on heavy load (+1000req/s) so i'm trying to find the most efficient (and safest) way to do this.

from socket.io-redis-adapter.

Valentinfe avatar Valentinfe commented on June 11, 2024

Thanks for your complete answer. We improved performances by a lot.

I'll share some benchmark result between the two options.
20Vcpu, 30Ghz allocated CPU, 32Go RAM

With publishOnSpecificResponseChannel to 'false' it takes 24Ghz on average and with it to 'true' it takes 19Ghz on average, so we have an improvement of 21%.

This tests are made with Vsphere metrics reporter and are not very precise so take it with caution.

Thanks again, I close this issue.

from socket.io-redis-adapter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.