Git Product home page Git Product logo

Comments (5)

arthcp avatar arthcp commented on August 11, 2024

Possible changes

  • Packing slugs in checkTransmitter of transmitManager
  • No need to emit capacitor address in PacketVerifiedAndSealed

from socket-dl.

arthcp avatar arthcp commented on August 11, 2024

Mostly all nonReentrant modifiers can be removed

from socket-dl.

arthcp avatar arthcp commented on August 11, 2024

Use location as storage instead of memory when reading structs from storage.

// bad
PlugConfig memory plugConfig = _plugConfigs[localPlug][remoteSlug];

// good
PlugConfig storage plugConfig = _plugConfigs[localPlug][remoteSlug];

from socket-dl.

ameeshaagrawal avatar ameeshaagrawal commented on August 11, 2024

Accessed storage variable less:

 uint256 packetCount = _sealedPackets++;

Removed redundant code:

  • imported SocketBase once with SocketDst
  • removed extra constructors

Packed _plugConfigs mapping:

// plug | remoteChainSlug => (siblingPlug, capacitor__, decapacitor__, inboundSwitchboard__, outboundSwitchboard__)
mapping(uint256 => PlugConfig) internal _plugConfigs;

Packed function params:

//bad
 function registerSwitchBoard(
        address switchBoardAddress_,
        uint256 siblingChainSlug_,
        uint256 capacitorType_
    ) external {

// good
 function registerSwitchBoard(
        address switchBoardAddress_,
        uint32 siblingChainSlug_,
        uint32 capacitorType_
    ) external {

from socket-dl.

arthcp avatar arthcp commented on August 11, 2024

implemented

from socket-dl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.