v5.0.15 will case error in react-native ios used in remote-redux-devtools about socketcluster-client HOT 12 CLOSED

Can also confirm that this breaks react-native, indeed because of 6c7f4e1.

from socketcluster-client.

@jondubois, here's the detailed log: zalmoxisus/remote-redux-devtools#51 (comment)

from socketcluster-client.

@zalmoxisus @feyy Does it work with v5.0.14?

from socketcluster-client.

This is the only change which was introduced in v5.0.15 6c7f4e1

from socketcluster-client.

I can roll it back if that's the problem.

from socketcluster-client.

It's strange because we use global here https://github.com/SocketCluster/socketcluster-client/blob/master/lib/scsocketcreator.js#L44 but it doesn't seem to cause any problems?

from socketcluster-client.

@jondubois, I didn't reproduce that. We updated the lib from socketcluster-client@4 to @5, so it's not related to a specific patch version I guess.

from socketcluster-client.

@zalmoxisus Can you find out which version introduced the problem? It's quite hard to setup react native on my Linux machine so I can't test.

from socketcluster-client.

@jondubois, I tried earlier versions. It appears only on 5.0.15. Removing global.WebSocket || from here solves the issue. Strangely, it appears only on iOS, not for Android.

from socketcluster-client.

@sjmueller @zalmoxisus Do you know if this issue has been resolved in newer versions of socketcluster-client? The logic that was causing problems was changed a while ago:

https://github.com/SocketCluster/socketcluster-client/blob/master/lib/sctransport.js#L7-L17

from socketcluster-client.

@jondubois the fix is landed on React Native >= 0.43, so the older versions of socketcluster-client should work as well.

from socketcluster-client.

Thanks @zalmoxisus :)

from socketcluster-client.