DW_DLE_ATTR_FORM_BAD (114) ERR_INVALID_DWARF: Failed to read DWARF from 'asan.o' about diva HOT 4 OPEN

Build with:

g++ asan.ii -g -c && ./bin/diva asan.o
DW_DLE_ATTR_FORM_BAD (114)
ERR_INVALID_DWARF: Failed to read DWARF from 'asan.o'

from diva.

Reproduced: repro.zip

Looks like gcc is now outputting template parameter values in block form rather than as integers (which is valid DWARF).

 DW_TAG_template_value_parameter
   DW_AT_name                  "b" <form DW_FORM_string>
   DW_AT_type                  <0x00000072> <form DW_FORM_ref4>
   DW_AT_const_value           03000000 <form DW_FORM_block1>

This has the same underlying problem as issue #1 (quick fixed), where we could account for more forms when reading attributes, and handle forms we aren't expecting better.

from diva.

As an aside I wonder why the value is now encoded as DW_FORM_block* (a collection of bytes) rather than DW_FORM_data*.

The reader of the DWARF can't interpret the value without knowing what the bytes represent. In this case they're a little endian integer but there is no way of 'knowing' that.

from diva.

The type is the DW_AT_type on the DW_TAG_template_value_parameter. If you look at DWARF, e.g. DWARF5 pdf, block class next to constant and string are the supported classes.
While this inefficiency has been fixed in the mean time in GCC 8, if you say have template parameter with say __int128_t type that doesn't fit into 64-bits (signed or unsigned), you'll get a block too.

from diva.