pre-commit autoupdate warning about pep585-upgrade HOT 7 CLOSED

I'm a bit torn on what to do, since removing the v1/v1.0 tags might break people's environments if they've already specified those explicitly right. It also seems weird to me that pre-commit upgrades to a mutable reference yet complains about it.

Then again, this is a pre-commit hook primarily, and it might make sense to just get rid of the unfit tags.

What do you think?

@JonasKs, do you have a take on this?

from pep585-upgrade.

I don't know if the problem will solve itself with the next release, if there is only 1.0.2 or 1.1.0 on the latest commit, depending on what it will be?

from pep585-upgrade.

I'm a bit torn on what to do, since removing the v1/v1.0 tags might break people's environments if they've already specified those explicitly right.

Do we need to remove tags? Or is it enough to release a new one? 🤔 I don't like the sound of removing tags 👀

from pep585-upgrade.

I think v1.2.0 would still be upgraded to v1, so a v2 release would be necessary to resolve the issue. Doubt pre-commit autoupdate will upgrade to v2 for you, so not sure that's a good solution either (but happy to be proven wrong about both points).

from pep585-upgrade.

I think a v2 will not solve the problem, at most v2.0.0 maybe. But I don't know that for sure. If it doesn't, only deleting would help, though I also see the problem that comes with that.
Whereby there is then either no update possibility or possibly some not working configs as alternatives. I would prefer the update option in the long run.

from pep585-upgrade.

Don't seem like it would necessarily require too much work to change the behavior of the autoupdate function if that's something they'd accept. Here's the relevant code.

from pep585-upgrade.

I'm officially deprecating this project, as pyupgrade now fills the gap this once did. The package can still be used, but I'm not intending to spend any more time maintaining it, so closing this for now 🙂

from pep585-upgrade.