Comments (7)
I'm a bit torn on what to do, since removing the v1/v1.0 tags might break people's environments if they've already specified those explicitly right. It also seems weird to me that pre-commit upgrades to a mutable reference yet complains about it.
Then again, this is a pre-commit hook primarily, and it might make sense to just get rid of the unfit tags.
What do you think?
@JonasKs, do you have a take on this?
from pep585-upgrade.
I don't know if the problem will solve itself with the next release, if there is only 1.0.2 or 1.1.0 on the latest commit, depending on what it will be?
from pep585-upgrade.
I'm a bit torn on what to do, since removing the v1/v1.0 tags might break people's environments if they've already specified those explicitly right.
Do we need to remove tags? Or is it enough to release a new one?
from pep585-upgrade.
I think v1.2.0 would still be upgraded to v1, so a v2 release would be necessary to resolve the issue. Doubt pre-commit autoupdate will upgrade to v2 for you, so not sure that's a good solution either (but happy to be proven wrong about both points).
from pep585-upgrade.
I think a v2 will not solve the problem, at most v2.0.0 maybe. But I don't know that for sure. If it doesn't, only deleting would help, though I also see the problem that comes with that.
Whereby there is then either no update possibility or possibly some not working configs as alternatives. I would prefer the update option in the long run.
from pep585-upgrade.
Don't seem like it would necessarily require too much work to change the behavior of the autoupdate function if that's something they'd accept. Here's the relevant code.
from pep585-upgrade.
I'm officially deprecating this project, as pyupgrade
now fills the gap this once did. The package can still be used, but I'm not intending to spend any more time maintaining it, so closing this for now 🙂
from pep585-upgrade.
Related Issues (12)
- Support for typing.cast call HOT 9
- Imports removal corrupts imports HOT 1
- Shebang is not respected HOT 4
- end_lineno error while running python 3.7 HOT 8
- I just want to say thank you :) HOT 1
- Create/push a tag for the package HOT 3
- Don't Upgrade Generics HOT 1
- Don't upgrade generics - part 2 HOT 11
- don't add another import line from same package HOT 1
- Import of ClassVar is replaced by ClassVarVar HOT 5
- Avoid duplicate futures imports
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pep585-upgrade.