Requirement check in upgrade.php does not validate OR dependencies correctly about snipe-it HOT 8 CLOSED

just strange that this is the first time it's reported

Indeed.

Maybe most people just use PHP GD, but I didn't install the module on our system because ImageMagick was already installed. Reduce attack surface and all that, you know.

from snipe-it.

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

from snipe-it.

That hasn't been changed in quite some time though - I'm surprised this hasn't come up before if it's a genuine bug. (Not saying it's not, just strange that this is the first time it's reported.)

from snipe-it.

That's certainly possible. I haven't used ImageMagick in a decade, since most systems already have gd installed. I'm not sure of a reliable way to test this though. :-/

from snipe-it.

I'm not sure of a reliable way to test this though

I just created a PR for this #14986 but also didn't fully test it by uninstalling extensions from my local system. I detailed how I "faked" it in the PR.

from snipe-it.

@marcusmoore i think that’s a good best effort here - Ty!

from snipe-it.

Thanks for reporting @pprs-it. This should be handled in #14986 so I'm going to close this issue. Please let us know if you still run into issues with it in the future.

from snipe-it.

Will do, thank you! 👍

from snipe-it.