Comments (3)
benerudolph
commented on August 22, 2024
It seems to me that sources are read into a fixed size char sources[]. When populating the array only sizeof(sources) items are copied over.
My suggestion for the resolution of this bug is to check for the size of the sources entry in the argv array and carry over this information to bgpq_expander.c:771 where sources char[] is built.
from bgpq3.
snar
commented on August 22, 2024
On Tue, Jul 11, 2017 at 04:23:34PM +0000, Pier Carlo Chiodi wrote:
Hello,
I'm facing an issue when passing a source list longer than 124 chars; it seems
the program hangs, both when the -S option or the IRRD_SOURCES env var are
used.
Maybe something wrong happens here?
Indeed, snprintf at line 773 truncated sources list so final CR character
was not included making IRRD think this request line is not complete yet.
Fixed version pushed to github, can you check if it fixes issue for you too ?
PS: just a curiosity question: what is the reason of using that large
source list ?
PPS: sorry for delay, just back from vacation.
…
125 chars, -S:
$ bgpq3 -d -S "1234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234_" -3 -j -f 1 -l asn_list AS3333
DEBUG: bgpq_expander.c:742 bgpq_expand Acquired sendbuf of 4608 bytes
DEBUG: bgpq_expander.c:771 bgpq_expand Requesting sources !s1234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234_^C
125 chars, IRRD_SOURCES:
$ IRRD_SOURCES="1234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234_" bgpq3 -d -3 -j -f 1 -l asn_list AS3333
DEBUG: bgpq_expander.c:742 bgpq_expand Acquired sendbuf of 4608 bytes
DEBUG: bgpq_expander.c:771 bgpq_expand Requesting sources !s1234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234_^C
124 chars, -S:
$ bgpq3 -d -S "1234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234" -3 -j -f 1 -l asn_list AS3333
DEBUG: bgpq_expander.c:742 bgpq_expand Acquired sendbuf of 4608 bytes
DEBUG: bgpq_expander.c:771 bgpq_expand Requesting sources !s1234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234
DEBUG: bgpq_expander.c:775 bgpq_expand Got answer F source(s) unavailable
ERROR:Invalid source(s) '1234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234': F source(s) unavailable
124 chars, IRRD_SOURCES:
$ IRRD_SOURCES="1234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234" bgpq3 -d -3 -j -f 1 -l asn_list AS3333
DEBUG: bgpq_expander.c:742 bgpq_expand Acquired sendbuf of 4608 bytes
DEBUG: bgpq_expander.c:771 bgpq_expand Requesting sources !s1234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234
DEBUG: bgpq_expander.c:775 bgpq_expand Got answer F source(s) unavailable
ERROR:Invalid source(s) '1234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234': F source(s) unavailable
Credits to @benerudolph and the other guys that participated in the Euro-IX
route server workshop for helping me out to analyze this.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.*
from bgpq3.
pierky
commented on August 22, 2024
Hello,
Fixed version pushed to github, can you check if it fixes issue for you too ?
it works, thanks.
PS: just a curiosity question: what is the reason of using that large
source list ?
Maybe @benerudolph can answer your question. I just filed this issue after I analyzed what initially looked like a bug in ARouteServer that he reported to me.
from bgpq3.
Related Issues (20)
- FATAL ERROR:EOF from RADB (dequeue, ripe) Exit Code 255 HOT 2
- Clarify Nokia (classic CLI) options HOT 2
- Feature Request: Do not print anything if 0 objects received HOT 4
- bgpq3 exit code is 255, stderr: b'FATAL ERROR:select timeout\n' HOT 2
- Limitations of bgpq3 -S HOT 1
- filter route and AS (possible feature request) HOT 2
- Rationale behind the recommended sources HOT 1
- Cisco IOS XR format lacks one space in indentation HOT 1
- Sequence numbers not respected with empty result HOT 1
- Subnet length wrong HOT 3
- Uncorrected as-patch filter for Huawei HOT 1
- Possibility of tagging a new release HOT 1
- Add BGPQ3 to Arista EOS HOT 5
- Allow generation of combined IPv4/IPv6 lists HOT 3
- About the operation when multiple database sources are specified by'-S flag'
- BSD-3 files
- Invalid symbol in ASN errors HOT 1
- Certain prefixes that show up in the RIPE GUI don't get outputted by BGPq3 when the ASSet is queried HOT 8
- missing some prefixes HOT 11
- Install on ASR9K
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bgpq3.