Git Product home page Git Product logo

Comments (4)

snake-biscuits avatar snake-biscuits commented on July 23, 2024

Maybe even providing a BranchScript class in bsp_tool.branches.base for fast prototyping could be useful
and maybe a method for copying an existing branch script to use as a base

being able to write a branch script to a .py file with a method would be ideal
(though a python class that prints itself is likely an interesting challenge)

from bsp_tool.

snake-biscuits avatar snake-biscuits commented on July 23, 2024

Added the BspLump & subclasses to allow loading lumps dynamically, but it's fairly limited
Still to re-support:

  • Editing lumps
  • Saving changes to file
  • Loading lzma compressed lumps

Also managed to break the simpler lump classes by trying to simplify things with a decorator
looks like it isn't overriding init like I'd hoped it would

from bsp_tool.

snake-biscuits avatar snake-biscuits commented on July 23, 2024

OK, most of the bugs brought on by new refactor appear to be resolved, and some new tests have been written just in case

Editing lumps still needs to be implemented, but once that's done saving changes only need some slight modifications
Compressed lumps will need reloading after writing, and internal diffs can be purged
Compressed lumps now load correctly with the current system, though they do store decompressed lumps in memory
Temporary files might be better for performance, but a nightmare to manage

So the only major addition required now is re-implementing editing lumps, it should work the same as before, though likely with a system for checking data is valid behind the scenes

Checking things like valid indices between lumps will be left to branch script methods
further breaking down the core methods might also make Inheritance easier, reducing the total volume of code again

from bsp_tool.

snake-biscuits avatar snake-biscuits commented on July 23, 2024

Changes can now be saved, Iā€™d say this feature is pretty much implemented. Obviously more iterations could be made but this issue can be closed now.

from bsp_tool.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    šŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. šŸ“ŠšŸ“ˆšŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ā¤ļø Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.