Comments (6)
smuellerDD
commented on August 22, 2024
Am Donnerstag, dem 18.03.2021 um 08:14 -0700 schrieb Daiki Ueno:
I noticed that the library constructor calls [prctl(PR_SET_DUMPABLE,
0)](https://github.com/smuellerDD/libkcapi/blob/master/lib/kcapi-kernel-if.c#L1392
) unconditionally. That makes any linked applications impossible to be
debugged with gdb, because the process cannot be attached via `ptrace`. I
suppose this has already been well considered, but could this be relaxed a
bit, e.g., by protecting only relevant pages with `madvise(MADV_DONTDUMP)`?
I usually compile the library with make debug when I want to debug it.
How do you view the dumpable protection in your projects? I mean I do not want
to protect debugging. But a crypto library should not simply dump its core.
Thanks
Stephan
from libkcapi.
ueno
commented on August 22, 2024
I generally agree that crypto libraries shouldn't dump sensitive data to its core. Let me clarify my concern a bit: I'm thinking to enable AF_ALG support in a GnuTLS distro package through libkcapi, once the current patches are ready. I worry that it could make any consumers of the package (e.g., GNOME applications) non-debuggable, even when the user wants to track issues in non-crypto code.
from libkcapi.
smuellerDD
commented on August 22, 2024
Am Donnerstag, dem 18.03.2021 um 09:28 -0700 schrieb Daiki Ueno:
So, you do not have similar protection mechanisms in GnuTLS? I also do not see
similar code in other crypto libs like libgcrypt, OpenSSL or NSS. So maybe I
am a bit over-zealous here?!
Ciao
Stephan
from libkcapi.
ueno
commented on August 22, 2024
So, you do not have similar protection mechanisms in GnuTLS?
No, we don't. Afaik, gnome-keyring and libsecret make use of MADV_DONTDUMP for sensitive data but not for the entire process memory. I might open an issue against GnuTLS to do similar :-)
from libkcapi.
smuellerDD
commented on August 22, 2024
After some study, I verified that libkcapi does not hold sensitive data. Thus, I removed the prctl flag for good.
But as soon as sensitive data is added, I will use MADV_DONTDUMP and mlock.
from libkcapi.
ueno
commented on August 22, 2024
Thank you!
from libkcapi.
Related Issues (20)
- Questions about dividing data into chunks HOT 5
- key size fixed at 32 bytes (need 52 for CAAM related "black" keys) HOT 3
- AEAD gcm(aes) decrypt failure HOT 15
- AF_ALG bind error HOT 1
- Kernel API patches Status HOT 3
- Specify key length for kcapi-enc HOT 2
- How to configure the cross compiler toolchain？ HOT 1
- Where does the function `kcapi_md_final` implement ? HOT 1
- 1.4.0: test suite failis with `error: clang frontend command failed with exit code 139` HOT 19
- Is `kcapi_handle` thread-safe? HOT 4
- Does LibkcAPI support CFB1/CFB8? HOT 2
- vmsplice() with SPLICE_F_GIFT should not be used on memory allocated from the heap (ie. calloc) HOT 2
- Hang on read call in _kcapi_common_read_data
- Can't get `kcapi_akcipher_init` with `rsa` working locally HOT 6
- Why SHA2-256 is the only hash crypto primitive for KDF in linux kernel crypto? HOT 7
- speed-tests: Bench of Asymmetric Cryptographic Algorithms HOT 3
- coreutils, etc. symlinks created in $PREFIX/libexec/libkcapi HOT 3
- 1.4.0: sha*hmac binaries has been removed? 🤔 HOT 9
- DRBG CAVP Issue HOT 2
- Unable to build on busy box HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libkcapi.