org.milyn.javabean.gen.ConfigGenerator null pointer issue about smooks HOT 3 CLOSED

Hi. What's the stack trace?

from smooks.

Sorry, It leaves no stack trace beside this one :

+1: java.lang.NullPointerException
    at org.milyn.javabean.gen.ConfigGenerator.main(ConfigGenerator.java:72)

when I launch it in Eclipse I can see that on line 72 there is

outputFile.getParentFile().mkdirs();

when I inspect outputFile.getParentFile() it is null though the outputfile variable is holding a genuine File instance.

from smooks.

The configuration generator has the following code:

String outputFileName = getArgument("-o", "Output File Path", true, args);
File outputFile = new File(outputFileName);
outputFile.getParentFile().mkdirs();

The issue description indicates that the tool was run on Microsoft Windows. When the tool is run on Windows, with a command line such as -o file.xml, outputFile.getParentFile() returns null (at least on JDK 1.6 and 1.7), because no directory has been specified with the file name. Using -o ./file.xml gets rid of the error.

Added guard checks in ConfigGenerator to prevent an exception for this case on Windows.

from smooks.