Git Product home page Git Product logo

Comments (6)

tfennelly avatar tfennelly commented on May 23, 2024

Hi Ioan. I'm getting this error on my machine using the changes you made for #55.

I'd suspect this is a JDK version issue. Smooks was always build on Java v5 and v6, using the Sun/Oracle JDK.

from smooks.

tfennelly avatar tfennelly commented on May 23, 2024

Btw... I've no issue with getting the build running on Java7 and on other JDK implementations (OpenJDK etc). I do think however that the Sun/Oracle JDKs should be the baseline. I'd also like it to continue working on Java 5 and Java 6 if possible.

from smooks.

ieugen avatar ieugen commented on May 23, 2024

I think it's ok to maintain compatibility with older JDKs if it's not expensive. However I don't have access to Java 5 and I have adopted OpenJDK - which is the basis for Oracle JDK. Also there should be very few/minor differences between them.

Personally I like driving change. For me supporting Java 7 as a minimum makes sens - since older JDK6 is EOL for some time now. However I do understand the need for backwards compatibility and I think we should have a clear road-map for this - if it makes sense.

For example: Smoks version 1.x should support Java 5 & 6 . Smooks 2.x - may require minimum Java 1.7 - if it makes sense.

from smooks.

tfennelly avatar tfennelly commented on May 23, 2024

+1 to everything you say there.

from smooks.

ieugen avatar ieugen commented on May 23, 2024

My locale is ro_RO and DateDecoding fails with java.text.ParseException: Unparseable date: "Wed Nov 15 13:45:28 EST 2006" .

I've seen this while debugging. The exception is not propagated which is bad - we should know if the text failed to parse because a date could not be parsed.

The test fails to decode using ro_RO. The test changes the default locale to en-IE during runSmooksTransform but date decoding is done during the getBean('order').

So I think we have two issues:

  • a locale issue during getBean - should we use the default locale - en-IN if none is specified instead or the system locale. Either way we should document this.
  • the date decoding exception is not propagated

@tfennelly: WDYT?

from smooks.

ieugen avatar ieugen commented on May 23, 2024

fixed #55

from smooks.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.