Consider renaming Async::new() about smol HOT 9 CLOSED

How about Async::pollable()?

from smol.

What about removing the Async::new() entirely and use Async::try_from() for all T: AsRawFd?
Maybe I should open a PR with that? (I mean for the impl TryFrom<T: AsRawFd> for Async<T>)

from smol.

stdio/out/err are actually pollable or not (just not on Windows)? I remember doing that quite a few times.

That of course depends on what your stdio streams happen to be. If they're on-disk files, they're not pollable. If they're ptys, or sockets, or pipes, they are 🙂 So it's definitely true that you cannot assume they're always pollable.

from smol.

Maybe instead of "socket", "pollable fd" would be a better term? It seems weird to call the various other kinds of pollable fds on Linux "sockets" :)

On Windows, Async::new() only accepts T: AsRawSocket so you really can only use sockets with it - the situation there is perfect.

This also seems like a good reason to rename, as one might want to add an Async::handle() in the future that works on HANDLEs, for example.

from smol.

@shekohex Interesting, haven't thought of that! But I worry people would do Async::try_from(file)?

@sdroege I like that - so we can explain Async is only for pollable things, which files and stdio aren't.

from smol.

@sdroege I like that - so we can explain Async is only for pollable things, which files and stdio aren't.

stdio/out/err are actually pollable or not (just not on Windows)? I remember doing that quite a few times.

from smol.

@stjepang As long as the AsRawFd bound is kept, you just can't stop people writing Async::try_from(file)?. However, you shouldn't because the method's name already suggests a known idiomatic approach most rust developers are familiar with.

from smol.

How about Async::pollable()?

Perhaps Async::polling(smth)? Though that sounds a bit Swift-ish.

from smol.

I decided to not change this :) It seems that the original issue hasn't come up again since the initial release of smol. That may be partly because more people have become familiarized with Async vs Unblock distinction, and partly because there are now higher-level crates like async-net and async-fs.

from smol.