protoc-gen-ng: Incorrect generation for AsObject interfaces in *.pb.ts files about ngx-grpc HOT 5 OPEN

The issue is fixed in v3.0.0, see CHANGELOG for details

from ngx-grpc.

Hi @smnbbrv,
in current v3.0.1 this issue is still not fixed. I'm sorry for taken that long to respond, but we needed to upgrade Angular first :)

To reproduce:

• clone repo
• npm i
• mkdir ./packages/protoc-gen-ng/test/out
• $(pwd)/node_modules/.bin/grpc_tools_node_protoc --plugin=protoc-gen-ng=$(pwd)/dist/protoc-gen-ng/main.js --ng_out=config=packages/protoc-gen-ng/ngx-grpc.conf.js:packages/protoc-gen-ng/test/out -I packages/protoc-gen-ng/test/proto $(find ./packages/protoc-gen-ng/test/proto -iname "*.proto")
• See file packages/protoc-gen-ng/test/out/maps.pb.ts line 455

In c1a86a6 it passes some options, are we supposed to configure this somehow, that nested AsObject types are used?

from ngx-grpc.

ahem, should be rechecked then

from ngx-grpc.

Hi @smnbbrv, do you accept PRs, maybe we can try to fix this?

from ngx-grpc.

Hi @oco2000

of course

from ngx-grpc.