Params type for new request about ngx-grpc HOT 8 CLOSED

It looks like TestRequest is a message and you are creating a message by new TestRequest(). The constructor accepts another instance of TestRequest or an object that looks like TestRequest or no value. In case you pass one of them and it is a value, all the properties will be deeply cloned and assigned to corresponding properties in this message. So, IDE works quite fine here.

Here is an example of actually running the request with passing the parameters and IDE works as expected as well:

Properties are also normally well-documented with jsdoc comments. I don't have WebStorm (I use VSCode) so I can't validate it there, however there is nothing special in the generated code that normal IDE would not be able to support

from ngx-grpc.

How do you know what object you should pass in a message constructor? For example in EchoRequest (message, shouldThrow and timestamp)?

In our case I can see that it is RecursivePartial<GetMessagesByFolderRequest> but IDE suggest only methods:

So, I need to go to the constructor or to the documentation to know what params I should pass:

from ngx-grpc.

The first two, that are offered by IDE are in fact getters. Those technically are methods but not ordinary ones, they behave like normal properties on the object. What does IDE insert in case you hit enter on let's say mailbox getter?

Here is what is displayed in VSCode:

from ngx-grpc.

If I choose getter method, IDE inserts the following:

from ngx-grpc.

I have just tried to use suggestions in VS Code and they work:

Apparently, the question is in the WebStorm.

from ngx-grpc.

Yes, I think so too.

Probably try to raise the issue at JetBrains team. If you find a way to make it more WebStorm-friendly (maybe some special comment for each getter or similar) please let me know.

from ngx-grpc.

Hi @bzvyagintsev

I just had a random idea that might help here. Could you change in the generated code constructor TestRequest(_value?: RecursivePartial<TestRequest>) to constructor TestRequest(_value?: RecursivePartial<TestRequest.AsObject>) and say whether this resolves the issue? This structure of this object is actually the same as the message but with normally defined properties.

from ngx-grpc.

Hi

This way it works as expected:

from ngx-grpc.