grpc-web v1.2.0 appears to be broken about ngx-grpc HOT 5 CLOSED

When I had 1.2.0 installed I would get a status event with code 0 and then nothing else would come through.

Yep, I see the same on my projects now. Looks like some of their underlying API is changed.

Out of curiosity, why are "peerDependencies" used rather than just a dependency?

Well, a long story short: in frontend projects in general its better to use peerDependencies over dependencies to avoid client side code duplication (e.g. when you have two projects importing different versions of the same library). In addition, as an end-consumer of the library you can easily override any dependency in "peerDependencies" by installing the one you want; with "dependencies" it is impossible; that's just how npm works. As a downside - the dependencies from "peerDependencies" aren't automatically installed. However, it's better evil :)

from ngx-grpc.

Hi there,

thanks for reporting!

The dependency in package.json is at "peerDependencies", so it does not really force anything; one should be able to use any matching version.

Need to investigate more on what's broken in 1.2.0. This lib doesn't use Promise implementation as far as I remember.

from ngx-grpc.

When I had 1.2.0 installed I would get a status event with code 0 and then nothing else would come through.

Out of curiosity, why are "peerDependencies" used rather than just a dependency?

from ngx-grpc.

This issue is a really good one, there are a lot of useful insides described in the connected issue on grpc-web side.

There is also an upcoming followup fix -> grpc/grpc-web#868 .

Please use latest version that fixes the issue.

from ngx-grpc.

@smnbbrv thanks for digging into it, looks like they have been very helpful.

from ngx-grpc.