Git Product home page Git Product logo

Comments (1)

sdumetz avatar sdumetz commented on September 13, 2024

After digging in a bit, I came with a prototype:

@@ -79,16 +86,24 @@ export default class CVSnapshots extends CTweenMachine
 
         const models = this.getGraphComponents(CVModel2);
         models.forEach(model => {
-            this.updateComponentTarget(model.transform, !!features["models"]);
             this.updateComponentTarget(model, !!features["models"]);
         });
 
         const lights = this.getGraphComponents(CLight);
         lights.forEach(light => {
-            this.updateComponentTarget(light.transform, !!features["lights"]);
             this.updateComponentTarget(light, !!features["lights"])
         });
 
+
+        const transforms = this.getGraphComponents(CVNode);
+        for(let transform of transforms){
+            let node = transform.node
+            if(!isNVNode(node)) continue;
+            if(node.camera) continue;
+
+            this.updateComponentTarget(transform, !!features["transforms"]);
+        }
+

The downside is: this introduces another tour "feature" users have to keep in mind, which I very much dislike. Especially since the concept of "transform" being a thing of its own, more or less separated from the underlying data object, while sound from a technical perspective (everybody does it internally) is not intuitive at all for non-technical users.

Leaving this here for later reference but I think I might be able to propose something better in the near future : I'm trying to optimize how the states array gets stored because it gets stupidly large on scenes with multiple objects, a large features set and many tour steps, which is very much the types of scenes I am working on.

from dpo-voyager.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.